Spec URL: http://fedorapeople.org/~cweyl/review/perl-PerlIO-gzip.spec SRPM URL: http://fedorapeople.org/~cweyl/review/perl-PerlIO-gzip-0.18-1.fc10.src.rpm Description: PerlIO::gzip provides a PerlIO layer that manipulates files in the format used by the gzip program. Compression and decompression are implemented. This is akin to Compress::Zlib, except that it operates at the lower PerlIO layer. Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1097838
Review: + package builds in mock (rawhide i386). koji build=>http://koji.fedoraproject.org/koji/taskinfo?taskID=1097838 + rpmlint is silent for SRPM and for RPM. + source files match upstream url 933fdf283a0d2739f7630420569e3b24 PerlIO-gzip-0.18.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test outputs All tests successful. Files=2, Tests=561, 0 wallclock secs ( 0.07 usr 0.00 sys + 0.70 cusr 0.07 csys = 0.84 CPU) + Package perl-PerlIO-gzip-0.18-1.fc11 -> Provides: gzip.so perl(PerlIO::gzip) = 0.18 Requires: libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.1.3) libc.so.6(GLIBC_2.4) libz.so.1 perl >= 0:5.008 perl(XSLoader) perl(strict) perl(warnings) rtld(GNU_HASH) APPROVED.
I'd say "gzip.so()" is a bit too generic as provides and leads to a potential clash in the future.
New Package CVS Request ======================= Package Name: perl-PerlIO-gzip Short Description: Perl extension to provide a PerlIO layer to gzip/gunzip Owners: cweyl Branches: F-9 F-10 devel InitialCC: perl-sig
cvs done.
Thanks for the review! :-)
as per #569299, Package Change Request ====================== Package Name: perl-PerlIO-gzip New Branches: EL-4 EL-5 Owners: iarnell InitialCC: perl-sig
Package Change Request ====================== Package Name: perl-PerlIO-gzip New Branches: epel7 Owners: psabata InitialCC: perl-sig
Git done (by process-git-requests).
Thank you.