Bug 483540 - Review Request: perl-Net-Stomp - Stomp client module for Perl
Review Request: perl-Net-Stomp - Stomp client module for Perl
Status: CLOSED NEXTRELEASE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
10
All Linux
low Severity medium
: ---
: ---
Assigned To: manuel wolfshant
Fedora Extras Quality Assurance
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2009-02-02 05:08 EST by Lubomir Rintel
Modified: 2009-02-03 04:41 EST (History)
2 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2009-02-03 04:41:01 EST
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
wolfy: fedora‑review+
kevin: fedora‑cvs+


Attachments (Terms of Use)

  None (edit)
Description Lubomir Rintel 2009-02-02 05:08:02 EST
SPEC: http://v3.sk/~lkundrak/SPECS/perl-Net-Stomp.spec
SRPM: http://v3.sk/~lkundrak/SRPMS/perl-Net-Stomp-0.34-1.el5.src.rpm

Description:

This module allows you to write a Stomp client. Stomp, the Streaming Text
Orientated Messaging Protocol, is a simple and easy to implement protocol
for working with Message Orientated Middleware.

Net::Stomp is can be used to communicate with Apache ActiveMQ, an
enterprise-level Java Message Service 1.1 (JMS) message broker.
Comment 1 manuel wolfshant 2009-02-02 07:06:35 EST
Package Review
==============

Key:
 - = N/A
 x = Check
 ! = Problem
 ? = Not evaluated

=== REQUIRED ITEMS ===
 [x] Package is named according to the Package Naming Guidelines.
 [x] Spec file name must match the base package %{name}, in the format %{name}.spec.
 [x] Package meets the Packaging Guidelines including the Perl specific items
 [x] Package successfully compiles and builds into binary rpms on at least one supported architecture.
     Tested on: devel/x86_64
 [x] Rpmlint output:
source RPM: empty
binary RPM:empty
 [x] Package is not relocatable.
 [x] Buildroot is correct (%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n))
 [x] Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines.
 [x] License field in the package spec file matches the actual license.
     License type: GPL+ or Artistic (same as perl)
 [x] If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc.
 [!] Spec file is legible and written in American English.
=> note 1
 [x] Sources used to build the package matches the upstream source, as provided in the spec URL.
     SHA1SUM of package: 19585101a90249ec972ec529d74594d6d2f7beee Net-Stomp-0.34.tar.gz
 [x] Package is not known to require ExcludeArch
 [x] All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines.
 [-] The spec file handles locales properly.
 [-] ldconfig called in %post and %postun if required.
 [x] Package must own all directories that it creates.
 [x] Package requires other packages for directories it uses.
 [x] Package does not contain duplicates in %files.
 [x] Permissions on files are set properly.
 [x] Package has a %clean section, which contains rm -rf %{buildroot}.
 [x] Package consistently uses macros.
 [x] Package contains code, or permissable content.
 [-] Large documentation files are in a -doc subpackage, if required.
 [x] Package uses nothing in %doc for runtime.
 [-] Header files in -devel subpackage, if present.
 [-] Static libraries in -devel subpackage, if present.
 [-] Package requires pkgconfig, if .pc files are present.
 [-] Development .so files in -devel subpackage, if present.
 [-] Fully versioned dependency in subpackages, if present.
 [x] Package does not contain any libtool archives (.la).
 [-] Package contains a properly installed %{name}.desktop file if it is a GUI application.
 [x] Package does not own files or directories owned by other packages.

=== SUGGESTED ITEMS ===
 [x] Latest version is packaged.
 [x] Package does not include license text files separate from upstream.
 [-] Description and summary sections in the package spec file contains translations for supported Non-English languages, if available.
 [x] Reviewer should test that the package builds in mock.
     Tested on: devel/x86_64
 [x] Package should compile and build into binary rpms on all supported architectures.
     Tested on: devel/x86_64
 [?] Package functions as described.
 [-] Scriptlets must be sane, if used.
 [-] The placement of pkgconfig(.pc) files is correct.
 [-] File based requires are sane.

===Notes===
1. please use:
"Net::Stomp can be used to communicate with Apache ActiveMQ, an enterprise-level Java Message Service 1.1 (JMS) message broker." as the last phrase in %Description ("is can" is not correct)


================
*** APPROVED ***
================
Comment 2 Lubomir Rintel 2009-02-02 09:48:14 EST
(In reply to comment #1)
> 1. please use:
> "Net::Stomp can be used to communicate with Apache ActiveMQ, an
> enterprise-level Java Message Service 1.1 (JMS) message broker." as the last
> phrase in %Description ("is can" is not correct)

Good catch! Thanks for the review (I'll address the wording issue during the import).

New Package CVS Request
=======================
Package Name: perl-Net-Stomp
Short Description: Stomp client module for Perl
Owners: lkundrak
Branches: EL-5 F-10
Comment 3 Kevin Fenzi 2009-02-02 23:32:06 EST
cvs done.
Comment 4 Lubomir Rintel 2009-02-03 04:41:01 EST
Imported and built. Thanks!

Note You need to log in before you can comment on or make changes to this bug.