Spec URL: http://atkac.fedorapeople.org/libbind.spec SRPM URL: http://atkac.fedorapeople.org/libbind-6.0-0.1.b1.fc11.src.rpm libbind was part of bind package but upstream has splitted libbind to separate tarball. Thus it makes sence to split it to separate package. Note about man pages - most of them currently conflict with glibc's manual pages so I removed them. (they are same as glibc's)
formal review is here, see the notes below: OK source files match upstream: 05affb35022128a71d8660b6bcb0b0858a49c330 libbind-6.0b1.tar.gz OK package meets naming and versioning guidelines. OK specfile is properly named, is cleanly written and uses macros consistently. OK dist tag is present. OK license field matches the actual license. OK license is open source-compatible. License text included in package. OK latest version is being packaged. OK BuildRequires are proper. OK* compiler flags are appropriate. OK %clean is present. OK package builds in mock (Rawhide/x86_64). OK debuginfo package looks complete. BAD rpmlint is silent. BAD final provides and requires look sane. N/A %check is present and all tests pass. OK shared libraries are added to the regular linker search paths. OK owns the directories it creates. BAD doesn't own any directories it shouldn't. OK no duplicates in %files. OK file permissions are appropriate. OK correct scriptlets present. OK code, not content. OK documentation is small, so no -docs subpackage is necessary. OK %docs are not necessary for the proper functioning of the package. OK headers in -devel OK no pkgconfig files. OK no libtool .la droppings. OK not a GUI app. - no need to manually export CFLAGS, the %configure macro takes care of that (rpmbuild --eval %configure) - rpmlint complains a bit libbind-devel.x86_64: W: obsolete-not-provided bind-devel libbind.x86_64: W: obsolete-not-provided bind-libs you should drop the F-7 bits and see https://fedoraproject.org/wiki/Packaging/NamingGuidelines#Renaming.2Freplacing_existing_packages for details and/or explain your variant with respect to the guideline libbind.x86_64: W: no-documentation you should include CHANGES, COPYRIGHT and README as %doc libbind.x86_64: W: shared-lib-calls-exit /usr/lib64/libbind.so.4.2.0 exit.5 IMHO can be ignored - you shouldn't own %{_includedir}/{arpa,net,sys} directories (list only the headers) and rather make a dependency on glibc-headers
Updated files: http://atkac.fedorapeople.org/libbind.spec http://atkac.fedorapeople.org/libbind-6.0-0.2.b1.fc11.src.rpm libbind.x86_64: W: obsolete-not-provided bind-libs Well, I don't think it is wise to put Provides: bind-libs to spec. "Old" bind-libs contained both bind-libs and libbind files. Some libraries have been splitted to libbind but some libraries are still in bind-libs. Due this reason I think we should not provide bind-libs.
few final notes: - the bind-libbind* Provides/Obsoletes can be completely removed, because bind-libbind was present only in F <= 7. - the bind-libs/bind-devel Obsolete should be removed too, because you are only moving one library into a separate package - freeciv, milter-greylist and dnscap should require an update of BuildRequires after importing libbind
Fixed package + spec: http://atkac.fedorapeople.org/libbind-6.0-0.3.b1.fc11.src.rpm http://atkac.fedorapeople.org/libbind.spec
All issues are fixed, this package is APPROVED.
New Package CVS Request ======================= Package Name: libbind Short Description: ISC's standard resolver library Owners: atkac Branches: devel InitialCC:
cvs done.
libbind is in rawhide and all dependant packages are successfully rebuilt.