Spec URL: http://orbsky.homelinux.org/packages/kde-plasma-ihatethecashew.spec Spec URL: ftp://orbsky.homelinux.org/pub/packages/kde-plasma-ihatethecashew.spec SRPM URL: http://orbsky.homelinux.org/packages/kde-plasma-ihatethecashew-0.2b-1.fc10.src.rpm SRPM URL: ftp://orbsky.homelinux.org/pub/packages/kde-plasma-ihatethecashew-0.2b-1.fc10.src.rpm Description: This is my first effort at packaging. It would be greatly appreciated if the package was reviewed. kde-plasma-ihatethecashew will create a plasmoid widget when added to the workspace will get rid of the "cashew" sitting on the top left of the KDE Workspace.
rpmlint output: kde-plasma-ihatethecashew.src: E: no-cleaning-of-buildroot %install - remove mkdir %{buildroot} kde-plasma-ihatethecashew.src: W: summary-ended-with-dot Removes the KDE Plasma Cashew From the Corner of the Display. - remove dot, summary shouldn't end with dot kde-plasma-ihatethecashew.src: E: description-line-too-long I don't like the cashew (the nasty icon in the right top corner of your plasma desktop kde-plasma-ihatethecashew.src: E: description-line-too-long that won't go away, even if plasma's locked)... It's impossible to remove this [cashew] - description is a little weird and full of emotions :) "I don't like..." is not a good description, please rewrite it in more polite and descriptive way. kde-plasma-ihatethecashew.x86_64: W: incoherent-version-in-changelog 0.2b ['0.2b-1.fc10', '0.2b-1'] - use release too * Mon Feb 02 2009 Eli Wapniarski <eli.org> 0.2b-1 Do not say "My first package" in Changelog, "Initial package" is OK
- use build root consistently - rm -rf $RPM_BUILD_ROOT -> rm -rf ${buildroot} - license matches COPYING but not ihtc.cpp (LGPLv2 is mentioned in header, should be GPLv2), ask upstream to correct it
I requested clarification for the licenses. Made the corrections as indicated in the above comments Spec URL: http://orbsky.homelinux.org/packages/kde-plasma-ihatethecashew.spec Spec URL: ftp://orbsky.homelinux.org/pub/packages/kde-plasma-ihatethecashew.spec SRPM URL: http://orbsky.homelinux.org/packages/kde-plasma-ihatethecashew-0.2b-2.fc10.src.rpm SRPM URL: ftp://orbsky.homelinux.org/pub/packages/kde-plasma-ihatethecashew-0.2b-2.fc10.src.rpm
Ops, sorry, I missed ${buildroot} - it should be 'rm -rf %{buildroot}'. rpmlint output: kde-plasma-ihatethecashew.x86_64: W: summary-ended-with-dot Removes the KDE Plasma Cashew From the Corner of the Display. - remove dot PS: check your SPEC, SRPM and RPM by rpmlint before uploading :)
Spec URL: http://orbsky.homelinux.org/packages/kde-plasma-ihatethecashew.spec Spec URL: ftp://orbsky.homelinux.org/pub/packages/kde-plasma-ihatethecashew.spec SRPM URL: http://orbsky.homelinux.org/packages/kde-plasma-ihatethecashew-0.2b-3.fc10.src.rpm SRPM URL: ftp://orbsky.homelinux.org/pub/packages/kde-plasma-ihatethecashew-0.2b-3.fc10.src.rpm
OK... Hopefull that's that. Thomas Luebking has indicated that he fixed the licensing test. The files seem to pass rpmlint Spec URL: http://orbsky.homelinux.org/packages/kde-plasma-ihatethecashew.spec Spec URL: ftp://orbsky.homelinux.org/pub/packages/kde-plasma-ihatethecashew.spec SRPM URL: http://orbsky.homelinux.org/packages/kde-plasma-ihatethecashew-0.2c-1.fc10.src.rpm SRPM URL: ftp://orbsky.homelinux.org/pub/packages/kde-plasma-ihatethecashew-0.2c-1.fc10.src.rpm
So... am I clear to move this to koji?
- rpmlint output is clean - OK - license is now clear (GPLv2) - OK - sources md5 - OK - koji scratch build http://koji.fedoraproject.org/koji/taskinfo?taskID=1103293 - OK - works as expected - OK It's OK for me, Rex, it's now your turn.
New Package CVS Request ======================= Package Name: kde-plasma-ihatethecashew Short Description: Removes the KDE Plasma Cashew From the Corner of the Display Owners: eliwap Branches: f-10 InitialCC: jreznik rdieter
Eli, please wait for the reviewer to set the proper flag (fedora-review must be "+", a "?" indicates only that the reviewer is going to review the package and should be set right in the beginning). To Jreznik: If you wanted to approve the package by this comment: "It's OK for me, Rex, it's now your turn." please set the proper flag and state that clearly, thanks.
Moreover, Eli, please: the GCC flags should be corrected, you can do that in a similar way like I suggested you in the review of kde-plasma-translatoid.
Eli: please be patient :) Milos: I didn't mean it as approved, we had deal with Rex to check this review and sponsor Eli.
OK.. Milos... Done. Jaroslav... OK Spec URL: http://orbsky.homelinux.org/packages/kde-plasma-ihatethecashew.spec Spec URL: ftp://orbsky.homelinux.org/pub/packages/kde-plasma-ihatethecashew.spec SRPM URL: http://orbsky.homelinux.org/packages/kde-plasma-ihatethecashew-0.2c-2.fc10.src.rpm SRPM URL: ftp://orbsky.homelinux.org/pub/packages/kde-plasma-ihatethecashew-0.2c-2.fc10.src.rpm
Oh.. Jaroslav.. By the way... In case you missed it... Rex has sponsored me.
I'm not sure about flags changes but we can deal with it later - it's not a blocker for me. APPROVED Eli, you can move on now ;-)
Thanks Jaroslav. Now its up to me to set the fedora-cvs request flag? Correct?
Yes, go ahead and set fedora-cvs to "?". Please copy the "New Package CVS Request" to your comment once again so as not to confuse the CVS administrators. You should also consider an F-9 branch.
(In reply to comment #17) > Yes, go ahead and set fedora-cvs to "?". Please copy the "New Package CVS > Request" to your comment once again so as not to confuse the CVS > administrators. > You should also consider an F-9 branch. Thanks for this comment, Eli should request f-9 and f-10 branch.
New Package CVS Request ======================= Package Name: kde-plasma-ihatethecashew Short Description: Removes the KDE Plasma Cashew From the Corner of the Display Owners: eliwap Branches: f-9 f-10 InitialCC: jreznik rdieter
Ahhh... OK. Thanks Jarosalv. I gotcha about the comment. Thanks for doing that for me. Eli
cvs done.
OK... I think... I hope... I've managed (it would seem to get everything built successfully for devel F-9 and F-10. Everything is available in koji. under builds. However, under Tags I only see dist-9. I just want to make sure that I got everything right.
Ok, now you have to fill in new package update in Bodhi for both F-9 and F-10 (not for rawhide).
Done. OK... I hope thats that... Wow.. Its a good thing to be able to contribute. But just a thought really... shuoldn't this process be a lot easier. I mean this should be go through a process to make sure you are who you say you are, then submit the appropriate files to the web interface and thats that. This process is way to convoluted. I feel like my head has been squeezed like a pimple.
You can match this #bz with updates in Bodhi. Yes, the process is really complicated but many steps are only one time. But this is not a good place to comment it.
(In reply to comment #25) > You can match this #bz with updates in Bodhi. I'm not quite sure I follow this one. Is this done when I run make update.
In Bodhi you can set bugzilla id and then this review is updated with current state of update and automatically closed once it hit stable repo.
I dare to comment on this here as I cannot agree with Jaroslav -- I think that exactly this is the right place and moment to try explaining the things to someone who just submitted his first package(s): (In reply to comment #24) > Done. OK... I hope thats that... Wow.. Its a good thing to be able to > contribute. But just a thought really... shuoldn't this process be a lot > easier. I mean this should be go through a process to make sure you are who you > say you are, then submit the appropriate files to the web interface and thats > that. After about a year being a Fedora packager, I think now I understand _why_ the process is so convoluted and, moreover, why it must be so. > This process is way to convoluted. I feel like my head has been squeezed like a > pimple. Yes, I had similar feelings after submitting my first package, but you should distinct between two different areas of complexity: - Packaging Guidelines -- they are definitely not short and may be seen as too strict, but they are really necessary if we want to keep certain quality level of our packages (and, at least in my opinion, the quality of our packages is a strong point of Fedora compared to other distributions) - all the technicalities around -- the review process, all the review/cvs flags, Koji, Bodhi, cvs access etc. -- all these things are really not as hard as they might appear for the first time and you'll get used to them. Many of those things are great tools or serve for better communication, you'll (hopefully) see. Hence, last but not least: thanks for packaging:)!
Milos: you're absolutely right, I agree with every word you've written! But this is review - place to help first time packager, place to review package but not to discuss if the process is good or not. I think correct place for it is devel mailing list. Thanks for help with review. ;-)
Bodhi update done. Thanks to all for their help. Just a quck comment. I think that since most of the work is done on the server this should be a form / script based process where one complete step triggers the next. I'm sure that I will get used to the process, but really, a simple check mark on a form after a stage is complete should trigger the next stage etc. The whole process once approved takes hours waiting for thing to complete when a simple click on an OK button would do the job with the message processing and email will be sent when completed or check back later. I understand the reason for all the steps. But all the steps are known required steps. This shouldn't be so convoluted. I agree with Jaroslav and this really isn't the correct forum for a discussion. So I beg that somebody else gets the last word on this. Please so you guys don't think I'm trying to get the last word. Just wanted to write something cause it got stuck in my head.
kde-plasma-ihatethecashew-0.2c-2.fc9 has been pushed to the Fedora 9 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing-newkey update kde-plasma-ihatethecashew'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F9/FEDORA-2009-1444
kde-plasma-ihatethecashew-0.2c-2.fc10 has been pushed to the Fedora 10 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update kde-plasma-ihatethecashew'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F10/FEDORA-2009-1468
kde-plasma-ihatethecashew-0.4-1.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/kde-plasma-ihatethecashew-0.4-1.fc11
kde-plasma-ihatethecashew-0.4-1.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/kde-plasma-ihatethecashew-0.4-1.fc12
kde-plasma-ihatethecashew-0.4-1.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report.
kde-plasma-ihatethecashew-0.4-1.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report.
After installing kde-plasma-ihatethecashew-0.4-1.fc11, the cashew reappeared on my desktop. If I attempt to add the Ihatethecashew widget, I get the message: "This object could not be created for the following reason: Could not find requested component: ihatethecashew". The plasmoid's shared library does in fact exist: $ rpm -ql kde-plasma-ihatethecashew /usr/lib/kde4/plasma_applet_ihatethecashew.so /usr/share/doc/kde-plasma-ihatethecashew-0.4 /usr/share/doc/kde-plasma-ihatethecashew-0.4/COPYING /usr/share/kde4/services/plasma-applet-ihatethecashew.desktop $ ls -l /usr/lib/kde4/plasma_applet_ihatethecashew.so -rwxr-xr-x 1 root root 29056 2009-12-21 00:04 /usr/lib/kde4/plasma_applet_ihatethecashew.so* Other plasmoids in the /usr/lib/kde4/ directory can be added successfully (e.g., Fuzzy Clock).
What happens if you uninstall then reinstall the plasmoid? If that doesn't correct the problem, please open up a bug report and I will pass this along upstream
The problem reoccurred after uninstall/reinstall so I opened a new bug report.
kde-plasma-ihatethecashew-0.4-2.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/kde-plasma-ihatethecashew-0.4-2.fc14
kde-plasma-ihatethecashew-0.4-2.fc13 has been submitted as an update for Fedora 13. https://admin.fedoraproject.org/updates/kde-plasma-ihatethecashew-0.4-2.fc13
kde-plasma-ihatethecashew-0.4-2.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report.
kde-plasma-ihatethecashew-0.4-2.fc14 has been pushed to the Fedora 14 stable repository. If problems still persist, please make note of it in this bug report.