Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.
For bugs related to Red Hat Enterprise Linux 5 product line. The current stable release is 5.10. For Red Hat Enterprise Linux 6 and above, please visit Red Hat JIRA https://issues.redhat.com/secure/CreateIssue!default.jspa?pid=12332745 to report new issues.

Bug 483793

Summary: [ipv6] Fix the return value of Set Hop-by-Hop options header with NULL
Product: Red Hat Enterprise Linux 5 Reporter: Dave Maley <dmaley>
Component: kernelAssignee: Jiri Pirko <jpirko>
Status: CLOSED ERRATA QA Contact: Red Hat Kernel QE team <kernel-qe>
Severity: medium Docs Contact:
Priority: medium    
Version: 5.3CC: anton, cward, davem, dzickus, emcnabb, nhorman, qcai, rkhan, tao, tgraf
Target Milestone: rc   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2009-09-02 08:48:54 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
reproducer
none
patch provided by partner none

Description Dave Maley 2009-02-03 16:59:52 UTC
Description of problem:
When use setsockopt() with option 'IPV6_DSTOPTS' but optval be set to NULL, kernel should return an error rather than 0.


Version-Release number of selected component (if applicable):
2.6.18-128.EL


How reproducible:
every time


Steps to Reproduce:
(see attached reproducer)
1. # gcc -o dstopt-6 dstopt-6.c
2. # ./dstopt-6
3.


Actual results:
Kernel return 0

Reproduce program log.
      # ./dstopt6
      == create an IPv6 socket ==
      == set Destination options header with NULL data pointer ==
      setsockopt() return: 0
      ERROR: success to set IPV6_DSTOPTS with NULL data pointer
      <=====NG=====>


Expected results:
Kernel return error EINVAL or EFAULT


Additional info:
The reproduction program:
  dstopt-6.c

The patch file is attached:
  file: net-fix-return-value-when-setsockopt-with-NULL-data-pointer.patch

This patch has already been applied for the Community's kernel.

Comment 1 Dave Maley 2009-02-03 17:01:24 UTC
Created attachment 330752 [details]
reproducer

# gcc -o dstopt-6 dstopt-6.c
# ./dstopt-6

Comment 2 Dave Maley 2009-02-03 17:03:48 UTC
Created attachment 330753 [details]
patch provided by partner

upstream info:
commit cfb266c0ee0ea0b7bfa8189e3a3a80344dec6112
Author: Yang Hongyang <yanghy.com>
Date:   Sun Aug 3 18:16:15 2008 -0700

Comment 5 RHEL Program Management 2009-02-16 15:32:15 UTC
Updating PM score.

Comment 6 RHEL Program Management 2009-02-27 14:27:48 UTC
This request was evaluated by Red Hat Product Management for inclusion in a Red
Hat Enterprise Linux maintenance release.  Product Management has requested
further review of this request by Red Hat Engineering, for potential
inclusion in a Red Hat Enterprise Linux Update release for currently deployed
products.  This request is not yet committed for inclusion in an Update
release.

Comment 7 Don Zickus 2009-03-04 20:01:31 UTC
in kernel-2.6.18-133.el5
You can download this test kernel from http://people.redhat.com/dzickus/el5

Please do NOT transition this bugzilla state to VERIFIED until our QE team
has sent specific instructions indicating when to do so.  However feel free
to provide a comment indicating that this fix has been verified.

Comment 10 Chris Ward 2009-07-03 18:23:07 UTC
~~ Attention - RHEL 5.4 Beta Released! ~~

RHEL 5.4 Beta has been released! There should be a fix present in the Beta release that addresses this particular request. Please test and report back results here, at your earliest convenience. RHEL 5.4 General Availability release is just around the corner!

If you encounter any issues while testing Beta, please describe the issues you have encountered and set the bug into NEED_INFO. If you encounter new issues, please clone this bug to open a new issue and request it be reviewed for inclusion in RHEL 5.4 or a later update, if it is not of urgent severity.

Please do not flip the bug status to VERIFIED. Only post your verification results, and if available, update Verified field with the appropriate value.

Questions can be posted to this bug or your customer or partner representative.

Comment 11 Chris Ward 2009-07-10 19:10:27 UTC
~~ Attention Partners - RHEL 5.4 Snapshot 1 Released! ~~

RHEL 5.4 Snapshot 1 has been released on partners.redhat.com. If you have already reported your test results, you can safely ignore this request. Otherwise, please notice that there should be a fix available now that addresses this particular request. Please test and report back your results here, at your earliest convenience. The RHEL 5.4 exception freeze is quickly approaching.

If you encounter any issues while testing Beta, please describe the issues you have encountered and set the bug into NEED_INFO. If you encounter new issues, please clone this bug to open a new issue and request it be reviewed for inclusion in RHEL 5.4 or a later update, if it is not of urgent severity.

Do not flip the bug status to VERIFIED. Instead, please set your Partner ID in the Verified field above if you have successfully verified the resolution of this issue. 

Further questions can be directed to your Red Hat Partner Manager or other appropriate customer representative.

Comment 14 errata-xmlrpc 2009-09-02 08:48:54 UTC
An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on therefore solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHSA-2009-1243.html