Spec URL: http://www.auroralinux.org/people/spot/review/new/tcl-trf.spec SRPM URL: http://www.auroralinux.org/people/spot/review/new/tcl-trf-2.1.3-1.fc11.src.rpm Description: Trf is an extension library to the script language tcl. It provides transformer procedures which change the flow of bytes through a channel in arbitrary ways. The underlying functionality in the core is that of stacked channels which allows code outside of the core to intercept all actions (read/write) on a channel. Among the applications of the above provided here are compression, charset recording, error correction, and hash generation.
Thanks, Hope this will be added soon, I need this library.
OK Rpmlint must be run on every package. OK The package must be named according to the Package Naming Guidelines. OK The spec file name must match the base package %{name}. OK The package must meet the Packaging Guidelines. OK The package must be licensed with a Fedora approved license. ? The License field in the package spec file must match the actual license. OK If (and only if) the source package includes the text of the license(s) in its own file. OK The spec file must be written in American English. OK The spec file for the package MUST be legible. OK The sources used to build the package must match the upstream source. 113c9766640239b17ee2dad4d3af4757 OK The package MUST successfully compile. OK Correct BuildRequires. OK Proper use of %find_lang macro. Using %{_datadir}/locale/* is strictly forbidden. OK Shared library files (not just symlinks) must call ldconfig in %post and %postun. OK Relocatable package must state this fact in the request for review. OK A package must own all directories that it creates. OK A package must not contain any duplicate files in the %files listing. OK Permissions on files must be set properly. OK Each package must have a %clean section, which contains rm -rf %{buildroot} (or $RPM_BUILD_ROOT). OK Each package must consistently use macros. OK The package must contain code, or permissable content. OK Large documentation files must go in a -doc subpackage. OK If a package includes something as %doc, it must not affect the runtime of the application. OK Header files must be in a -devel package. OK Static libraries must be in a -static package. OK Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig'. OK Library files with a suffix (e.g. libfoo.so.1.1) and files that end in .so (without suffix) must go in -devel. OK In the vast majority of cases, devel packages must require the base package. OK Packages must NOT contain any .la libtool archives. OK Packages containing GUI applications must include a %{name}.desktop file. OK At the beginning of %install, each package MUST run rm -rf %{buildroot} (or $RPM_BUILD_ROOT). Licenses: Hybrid BSD (half BSD, half zlib) in bzlib.h, sha.h is openssl license? generic/haval hasn't license at all... Could you check it once more and set the appropriate one? I didn't find any license file, what upstream says about license?
Well, I got all of the licensing cleared up on this one except for the RipeMD stuff, that's all non-free, so I need to pull that code out. :/
Okay, I'm pretty sure I have it all settled now: New SRPM: http://auroralinux.org/people/spot/review/new/tcl-trf-2.1.3-2.fc11.src.rpm New SPEC: http://auroralinux.org/people/spot/review/new/tcl-trf.spec
You've probably got all of them. I'm sorry but I'm still unsure about those files: trf2.1.3/compat/stdlib.h trf2.1.3/compat/tcl*.c They are speaking about some license.terms, which are not there. Could be tcl* files under tcl license?
They are files from TCL, thus, under the TCL license. However, they're not used on Linux (we have stdlib.h so we never include compat/stdlib.h, and the compat/tcl* code is only used on windows or cross-compile environments).
Ok, ACCEPT
New Package CVS Request ======================= Package Name: tcl-trf Short Description: Tcl extension providing transformer commands Owners: spot Branches: F-9 F-10 devel InitialCC: ... and it's done.
tcl-trf-2.1.3-2.fc9 has been submitted as an update for Fedora 9. http://admin.fedoraproject.org/updates/tcl-trf-2.1.3-2.fc9
tcl-trf-2.1.3-2.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/tcl-trf-2.1.3-2.fc10
tcl-trf-2.1.3-2.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report.
tcl-trf-2.1.3-2.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report.