Spec URL: http://fedorapeople.org/~cweyl/review/perl-DateTime-Format-Excel.spec SRPM URL: http://fedorapeople.org/~cweyl/review/perl-DateTime-Format-Excel-0.2901-1.fc10.src.rpm Description: Excel uses a different system for its dates than most Unix programs. This module allows you to convert between a few of the Excel raw formats and DateTime objects, which can then be further converted via any of the other DateTime::Format::* modules, or just with DateTime's methods.If you happen to be dealing with dates between 1 Jan 1900 and 1 Mar 1900 please read the notes on EPOCHS. If you're wanting to handle actual spreadsheet files, you may find the Spreadsheet::WriteExcel manpage and the Spreadsheet::ParseExcel manpage of use. Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1110940
Review: + package builds in mock (rawhide i386). + rpmlint is silent for SRPM and for RPM. - source files match different upstream url d2f1934833c247b50088fd7999efee04 DateTime-Format-Excel-0.2901.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test outputs All tests successful. Files=3, Tests=77, 0 wallclock secs ( 0.02 usr 0.00 sys + 0.34 cusr 0.02 csys = 0.38 CPU) + Package perl-DateTime-Format-Excel-0.2901-1.fc11-> Provides: perl(DateTime::Format::Excel) = 0.2901 Requires: perl >= 0:5.005 perl(Carp) perl(DateTime) >= 0.1705 perl(strict) perl(vars) Suggestion: 1) fix source url to http://cpan.perl.org/authors/id/D/DR/DROLSKY/DateTime-Format-Excel-0.2901.tar.gz APPROVED.
New Package CVS Request ======================= Package Name: perl-DateTime-Format-Excel Short Description: Convert between DateTime and Excel dates Owners: cweyl Branches: F-9 F-10 devel InitialCC: perl-sig
cvs done.
Thanks for the review! :-)