Bug 484681 - /usr/bin/rhn-config-schema.pl not needed in /etc/sudoers
Summary: /usr/bin/rhn-config-schema.pl not needed in /etc/sudoers
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Red Hat Satellite 5
Classification: Red Hat
Component: Server
Version: 530
Hardware: All
OS: Linux
low
medium
Target Milestone: ---
Assignee: Jan Pazdziora
QA Contact: wes hayutin
URL:
Whiteboard:
Depends On:
Blocks: 457079
TreeView+ depends on / blocked
 
Reported: 2009-02-09 14:57 UTC by Jan Pazdziora
Modified: 2009-09-10 19:11 UTC (History)
1 user (show)

Fixed In Version: sat530
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2009-09-10 19:11:35 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)

Description Jan Pazdziora 2009-02-09 14:57:26 UTC
Description of problem:

The default installation of Satellite 5.3.0 adds /usr/bin/rhn-config-schema.pl to alias INSTALL_RHN in /etc/sudoers.

I've grepped Spacewalk source and rhn-config-schema.pl appears to be called in two places -- in spacewalk/setup/lib/Spacewalk/Setup.pm, and in web/modules/rhn/RHN/SatInstall.pm. That Spacewalk::Setup is being used by root, so no sudo is needed (and called) there. That RHN::SatInstall calls

sub populate_tablespace_name {
  my $class = shift;
  my $tablespace_name = shift;

  my $sat_schema = File::Spec->catfile(DEFAULT_RHN_ETC_DIR, 'universe.satellite.sql');
  my $sat_schema_deploy =
    File::Spec->catfile(DEFAULT_RHN_ETC_DIR, 'universe.deploy.sql');

  my $ret = system("/usr/bin/sudo", "/usr/bin/rhn-config-schema.pl",
                   "--source=" . $sat_schema,
                   "--target=" . $sat_schema_deploy,
                   "--tablespace-name=${tablespace_name}",
                  );

  if ($ret) {
    throw 'There was a problem populating the universe.deploy.sql file.';
  }

  return;
}

But the function / method populate_tablespace_name is only called from method populate_database of RHN::SatInstall, and populate_database not used in the whole Spacewalk codebase. Therefore I assume it is dead code which can be removed, and so can /usr/bin/rhn-config-schema.pl from /etc/sudoers.

Note: I did this scan through our code to figure out if there are some commands that need additional SELinux treatment.

Version-Release number of selected component (if applicable):

Satellite-5.3.0-RHEL5-re20090206.1

How reproducible:

Deterministic.

Steps to Reproduce:
1. Install Satellite 5.3.0.
2. Look into /etc/sudoers.
  
Actual results:

/usr/bin/rhn-config-schema.pl is there.

Expected results:

/usr/bin/rhn-config-schema.pl is not there and Satellite continues to work OK.

Additional info:

This bug was modelled based on bug 484680.

Comment 1 Jan Pazdziora 2009-02-10 12:25:20 UTC
The proposed change is to remove the INSTALL_RHN section and merge whatever needs to be there to CONFIG_RHN. The proposed sudoers.rhn is below. I've tested that with this, the Satellite/Spacewalk works and runs external commands fine.

## RHN specifics ##
Cmnd_Alias CONFIG_RHN = /usr/sbin/rhn-sat-restart-silent,\
                        /usr/bin/rhn-config-satellite.pl,\
                        /usr/bin/rhn-satellite-activate,\
                        /usr/bin/rhn-bootstrap,\
                        /usr/bin/rhn-ssl-tool,\
                        /usr/bin/rhn-ssl-dbstore,\
                        /usr/bin/rhn-load-ssl-cert.pl,\
                        /etc/rc.d/np.d/step Monitoring install,\
                        /etc/rc.d/np.d/step MonitoringScout install,\
                        /etc/rc.d/np.d/step Monitoring uninstall,\
                        /etc/rc.d/np.d/step MonitoringScout uninstall,\
                        /sbin/service Monitoring restart,\
                        /sbin/service MonitoringScout restart,\
                        /sbin/service taskomatic restart

# The CONFIG_RHN commands are required for reconfiguration of a
# running RHN Satellite.  They should be enabled for proper operation
# of the RHN Satellite.
apache  ALL=(root)      NOPASSWD: CONFIG_RHN
tomcat  ALL=(root)      NOPASSWD: CONFIG_RHN

# These two directives allow tomcat and apache to invoke CONFIG_RHN
# commands via sudo even without a real tty
Defaults:tomcat !requiretty
Defaults:apache !requiretty

Comment 2 Clifford Perry 2009-02-10 17:04:53 UTC
This is a throw back from the old Installer - where we had command line install laid down packages. The WebUI then went through configuration/installation of Satellite to get it running, with many many steps, unlike the new WebUI portion that just asks for Username/password to be created for Sat Admin account. 

Cliff.

Comment 3 Jan Pazdziora 2009-02-11 07:25:57 UTC
Reassigning to myself as the bugzillas are not tracked against the SELinux feature.

Comment 4 Jan Pazdziora 2009-02-11 07:28:03 UTC
The previous comment should have been "are *now*".

Comment 5 Jan Pazdziora 2009-02-17 10:18:54 UTC
Committed to Spacewalk repo, 2fd863426ebf83cda3705b68fe98b48cbb0873e2 and e0e2df05d89a00945517c9403603a45e9a16c7f3.

Comment 6 Jan Pazdziora 2009-02-24 12:30:50 UTC
With compose Satellite-5.3.0-RHEL5-re20090220.1 available, moving ON_QA.

Comment 7 wes hayutin 2009-02-25 19:05:07 UTC
[root@grandprix ~]# cat /etc/sudoers | grep  /usr/bin/rhn-config-schema.pl
[root@grandprix ~]# 

ISO: Satellite-5.3.0-RHEL5-re20090220.1-i386-embedded-oracle.iso
verified

Comment 8 Miroslav Suchý 2009-08-26 09:28:11 UTC
[root@xen5 ~]# grep rhn-config-schema.pl /etc/sudoers
[root@xen5 ~]#

satellite works fine

verified in stage on xen5

Comment 9 Brandon Perkins 2009-09-10 19:11:35 UTC
An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on therefore solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHEA-2009-1434.html


Note You need to log in before you can comment on or make changes to this bug.