Bug 485181
| Summary: | Dock/Undock+ CDROM support for X61 and other laptops | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Red Hat Enterprise Linux 5 | Reporter: | Huzaifa S. Sidhpurwala <huzaifas> | ||||
| Component: | kernel | Assignee: | John Feeney <jfeeney> | ||||
| Status: | CLOSED ERRATA | QA Contact: | Red Hat Kernel QE team <kernel-qe> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | low | ||||||
| Version: | 5.3 | CC: | benl, cmeadors, cward, dzickus, jane.lv, jfeeney, jvillalo, ling.yue, ltroan, luyu, martinez, mgahagan, rlerch, syeghiay | ||||
| Target Milestone: | rc | ||||||
| Target Release: | 5.4 | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2009-09-02 09:00:17 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | |||||||
| Bug Blocks: | 252219, 296431, 444652, 446125, 481575, 483701, 483784, 496328 | ||||||
| Attachments: |
|
||||||
|
Description
Huzaifa S. Sidhpurwala
2009-02-12 05:25:39 UTC
I've backported the code from current upstream - I'll do a scratch build now. Jane, Matthew, Matthew, if you need help testing your patches, I think Jane can help out with the testing. I believe some of the hardware to test with. John and Matthew, Is X61 the specific hardware to reproduce this issue? I don't have X61 laptop. I only have a T61 but didn't reproduce this bug on it. I tried to reproduce this bug with RHEL5.3 (2.6.18-128 kernel) on the T61 laptop with a DVD-ROM in the dock station (actually I uninstalled the DVD-ROM from the T61 laptop and inserted it into the dock station slot.). After I un-dock and re-dock the laptop, the DVD still works and the DVD folder comes up on the top of screen automatically after I re-dock. Is there any chance of getting a kernel built so this can be tested. There are a couple of docking/hotplug bugzillas that might be fixed with this fix. Please let me know if I can be of any help (other than testing because I don't have the hardware). Kernel is at https://brewweb.devel.redhat.com/taskinfo?taskID=1783345 but doesn't fix this issue for X60+dock - the dock drive is being grabbed by the legacy IDE drivers, so the hotplug doesn't work. Huzaifa, could you please let me know whether the CD drive appears as hda or sr0 on the machine you've been testing? Ok. Works with this patch and the following boot options: piix.intel_via_libata=1 ide0=noprobe ide1=noprobe Which causes the CD drive to be driven via libata rather than via the legacy IDE layer. I can now dock and undock with absolute impunity. John, can you grab the kernel from Brew and boot with those boot options, then check whether the component bay works correctly? This would presumably need to be documented somewhere. The reason for requiring the boot option is to prevent users from finding their drives have suddenly renamed themselves unexpectedly - we can't make this the default behaviour at this stage. For ease of access, I copied the x86_64 and i686 rpms with this fix to my people page. See http://people.redhat.com/jfeeney/.bz485181 So where are we with this? I hope no one is waiting on me (see comment #18) because I don't have a CD drive to insert into my Dell dock. This looks like it could be added to 5.4 if we get it tested and posted asap. Created attachment 342522 [details]
Matthew's patch
I believe that this is Matthew's patch from the posted kernel. I took it from the SRPM out of brew.
I tested kernel from comment #19 with boot parameters "piix.intel_via_libata=1 ide0=noprobe ide1=noprobe" on my T61 laptop. No visible issue was found. libata driver is used by the CDROM in the dock instead of ide driver. Since Matthew Garrett posted a fix for bz444652, this bz (bz485181) should be fixed as well so setting status to POST. *** Bug 252219 has been marked as a duplicate of this bug. *** *** Bug 444652 has been marked as a duplicate of this bug. *** in kernel-2.6.18-149.el5 You can download this test kernel from http://people.redhat.com/dzickus/el5 Please do NOT transition this bugzilla state to VERIFIED until our QE team has sent specific instructions indicating when to do so. However feel free to provide a comment indicating that this fix has been verified. I did a regression test on T61 laptop with kernel-2.6.18-150.el5. No visible issue was found. ~~ Attention - RHEL 5.4 Beta Released! ~~ RHEL 5.4 Beta has been released! There should be a fix present in the Beta release that addresses this particular request. Please test and report back results here, at your earliest convenience. RHEL 5.4 General Availability release is just around the corner! If you encounter any issues while testing Beta, please describe the issues you have encountered and set the bug into NEED_INFO. If you encounter new issues, please clone this bug to open a new issue and request it be reviewed for inclusion in RHEL 5.4 or a later update, if it is not of urgent severity. Please do not flip the bug status to VERIFIED. Only post your verification results, and if available, update Verified field with the appropriate value. Questions can be posted to this bug or your customer or partner representative. ~~ Attention Partners - RHEL 5.4 Snapshot 1 Released! ~~ RHEL 5.4 Snapshot 1 has been released on partners.redhat.com. If you have already reported your test results, you can safely ignore this request. Otherwise, please notice that there should be a fix available now that addresses this particular request. Please test and report back your results here, at your earliest convenience. The RHEL 5.4 exception freeze is quickly approaching. If you encounter any issues while testing Beta, please describe the issues you have encountered and set the bug into NEED_INFO. If you encounter new issues, please clone this bug to open a new issue and request it be reviewed for inclusion in RHEL 5.4 or a later update, if it is not of urgent severity. Do not flip the bug status to VERIFIED. Instead, please set your Partner ID in the Verified field above if you have successfully verified the resolution of this issue. Further questions can be directed to your Red Hat Partner Manager or other appropriate customer representative. An advisory has been issued which should help the problem described in this bug report. This report is therefore being closed with a resolution of ERRATA. For more information on therefore solution and/or where to find the updated files, please follow the link below. You may reopen this bug report if the solution does not work for you. http://rhn.redhat.com/errata/RHSA-2009-1243.html Removing needinfo, since this is no longer relevant. |