Spec URL: http://konradm.fedorapeople.org/fedora/SPECS/irc-otr.spec SRPM URL: http://konradm.fedorapeople.org/fedora/SRPMS/irc-otr-0.3-1.fc10.src.rpm Description: This provides modules which implement Off-The-Record (OTR) Messaging for a number of popular IRC clients. Builds in Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=1129261
(Rpmlint output is clean.)
*** Bug 480872 has been marked as a duplicate of this bug. ***
I happen to use xchat :)
Package Review ============== Key: - = N/A x = Check ! = Problem ? = Not evaluated === REQUIRED ITEMS === [x] Package is named according to the Package Naming Guidelines. [x] Spec file name must match the base package %{name}, in the format %{name}.spec. [x] Package meets the Packaging Guidelines. [x] Package successfully compiles and builds into binary rpms on at least one supported architecture. Tested on: devel/x86_64 [x] Rpmlint output: source RPM: empty binary RPM:empty [x] Package is not relocatable. [x] Buildroot is correct (%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)) [x] Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x] License field in the package spec file matches the actual license. License type: GPLv2+ => see also note 1 [x] If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x] Spec file is legible and written in American English. [x] Sources used to build the package match the upstream source, as provided in the spec URL. SHA1SUM of package: 1481ac792aa58d9a7ce20d51b93eca0a28941ff4 irc-otr-0.3.tar.gz [x] Package is not known to require ExcludeArch. [x] All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [-] The spec file handles locales properly. [-] ldconfig called in %post and %postun if required. [x] Package must own all directories that it creates. [x] Package requires other packages for directories it uses. [x] Package does not contain duplicates in %files. [x] Permissions on files are set properly. [x] Package has a %clean section, which contains $RPM_BUILD_ROOT. [x] Package consistently uses macros. [x] Package contains code, or permissable content. [-] Large documentation files are in a -doc subpackage, if required. [x] Package uses nothing in %doc for runtime. [-] Header files in -devel subpackage, if present. [-] Static libraries in -devel subpackage, if present. [x] Package requires pkgconfig, if .pc files are present. [-] Development .so files in -devel subpackage, if present. [-] Fully versioned dependency in subpackages, if present. [x] Package does not contain any libtool archives (.la). [-] Package contains a properly installed %{name}.desktop file if it is a GUI application. [x] Package does not own files or directories owned by other packages. [x] Final provides and requires are sane. === SUGGESTED ITEMS === [x] Latest version is packaged. [x] Package does not include license text files separate from upstream. [-] Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x] Reviewer should test that the package builds in mock. Tested on: devel/x86_64, F10/x86_64 [x] Package should compile and build into binary rpms on all supported architectures. Tested on: koji scratch build [x] Package functions as described. ==> see note 2 [-] Scriptlets must be sane, if used. [-] The placement of pkgconfig(.pc) files is correct. [-] File based requires are sane. [-] %check is present and the test passes. === Final Notes === 1. <pedantic mode on> Please ask the upstream author to add the licensing bits to all the source files. <pedantic mode off> 2. Only tested in xchat. /otr genkey is painfully slow, I am sure this can be improved in the code. please ping the author, I hardly believe that 12 minutes on an AMD X2 5600+ is normal, even if it was idle and there was a message saying "This might take several minutes or on some systems even an hour". ================ *** APPROVED *** ================
Re 1: Asked. Re 2: That's probably your system being out of random data, not slowness. It took <15 seconds here. Try running 'du / >dev/null 2>&1' at the same time. Thanks for the review!
New Package CVS Request ======================= Package Name: irc-otr Short Description: Off-The-Record Messaging plugin for various irc clients Owners: konradm Branches: F-10 InitialCC:
cvs done.
Built in rawhide and F-10 a while ago, forgot to close this bug. Closing now.