Spec URL: http://ebaron.fedorapeople.org/eclipse-valgrind/eclipse-valgrind.spec SRPM URL: http://ebaron.fedorapeople.org/eclipse-valgrind/eclipse-valgrind-0.1.0-1.fc10.src.rpm Description: Eclipse plugins to integrate the Valgrind tool suite into the workbench.
Thanks for the submission. Here's the review. Lines beginning with X need attention; those beginning with * are okay: * verify the final provides and requires of the binary RPMs X make sure lines are <= 80 characters - please add some line continuations to fix this on line 37 * package successfully compiles and builds * BuildRequires are proper * macros fine * package is named appropriately * it is legal for Fedora to distribute this * license field matches the actual license. * license is open source-compatible. * specfile name matches %{name} * md5sum matches upstream * skim the summary and description for typos, etc. X summary and description good - please add Eclipse somewhere in the Summary. Something like "Eclipse plugin for Valgrind". The description could be a bit more verbose, too. * correct buildroot * %{?dist} used correctly * license text included in package and marked with %doc * packages meets FHS (http://www.pathname.com/fhs/) * rpmlint on <this package>.srpm gives no output * changelog format okay * Summary tag does not end in a period * no PreReq * specfile is legible * specfile written in American English * no -doc sub-package necessary * not native, so no rpath, static linking, etc. * no config files * not a GUI app * no -devel necessary * install section begins with rm -rf $RPM_BUILD_ROOT or %{buildroot} * no translations so no locale handling * no Requires(pre,post) * package not relocatable * package contains code * package owns all directories and files * no %files duplicates * file permissions fine * %clean present * %doc files do not affect runtime * not a web app * package includes license text in the package and marks it with %doc X run rpmlint on the binary RPMs => no output eclipse-valgrind.x86_64: E: no-binary eclipse-valgrind.x86_64: E: only-non-binary-in-usr-lib I know I told you to put this into /usr/lib{,64}, but let's put the JARs into /usr/share/eclipse and then just make sure that the package is not noarch. Is there an ExcludeArch on ppc64 because there's no valgrind on ppc64? * I verified that it installs and that the valgrind feature is available.
Fixed Spec and SRPM have been uploaded. BuildArch has been changed to noarch due to RPM lint errors, although there are arch-dependent dependencies. The exclusion of ppc64 is due to no eclipse-cdt on ppc64.
I see that you dropped the ppc64 ExcludeArch. I think this is for the best. If the CDT starts building on ppc64 (an upstream issue AFAIK) then this will not need any changes. If it doesn't, you may just have builds that fail in koji if the ppc64 builder is chosen for your noarch package. Hopefully that won't happen too often. Other issues have been dealt with and rpmlint is now silent on both the SRPM and noarch RPM. I think we're good to go here. Thanks! APPROVED. Please follow the procedure here: https://fedoraproject.org/wiki/Package_Review_Process which, as a next step has you follow this: https://fedoraproject.org/wiki/PackageMaintainers/CVSAdminProcedure
New Package CVS Request ======================= Package Name: eclipse-valgrind Short Description: Eclipse plugins to integrate the Valgrind tool suite into the workbench. Owners: ebaron Branches: F-10 InitialCC: overholt
cvs done.
Elliott, You builded the plugin in rawhide so will you close the bug? Thanks, Alexander Kurtakov
Completed.