Spec URL: http://fedorapeople.org/~cweyl/review/perl-CPANPLUS-Shell-Default-Plugins-Diff.spec SRPM URL: http://fedorapeople.org/~cweyl/review/perl-CPANPLUS-Shell-Default-Plugins-Diff-0.01-2.fc10.src.rpm Description: This plugin allows you to diff 2 versions of modules from within the CPANPLUS shell and see what code changes have taken place. Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1133957
Review: + package builds in mock (rawhide i386). koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=1133957 + rpmlint is silent for SRPM and for RPM. + source files match upstream url 0d8ad0864a840a7ae2654953c2d0f380 CPANPLUS-Shell-Default-Plugins-Diff-0.01.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test gave All tests successful. Files=1, Tests=5, 0 wallclock secs ( 0.00 usr 0.00 sys + 0.06 cusr 0.00 csys = 0.06 CPU) + Package perl-CPANPLUS-Shell-Default-Plugins-Diff-0.01-2.fc11 => Provides: perl(CPANPLUS::Shell::Default::Plugins::Diff) = 0.01 Requires: perl(CPANPLUS::Error) perl(Data::Dumper) perl(File::Basename) perl(Locale::Maketext::Simple) perl(Params::Check) perl(Text::Diff) perl(strict) perl(vars) APPROVED.
New Package CVS Request ======================= Package Name: perl-CPANPLUS-Shell-Default-Plugins-Diff Short Description: Diff module versions from the CPANPLUS shell Owners: cweyl Branches: F-9 F-10 devel InitialCC: perl-sig
cvs done.
Thanks for the review! :-)