Spec URL: http://www.bachelot.org/fedora/SPECS/php-pear-Crypt_Blowfish.spec SRPM URL: http://www.bachelot.org/fedora/SRPMS/php-pear-Crypt_Blowfish-1.1.0-0.1.rc2.fc10.src.rpm Description: This package allows you to perform two-way blowfish encryption on the fly using only PHP. This package does not require the MCrypt PHP extension to work, although it can make use of it if available.
First notes : - It requires PEAR >= 1.7.2 (according to upstream and to xml) : this will block this package for EPEL. - rpmlint warning : W: summary-not-capitalized quick two-way blowfish encryption - %file must be fixed %files %defattr(-,root,root,-) %{pear_xmldir}/%{pear_name}.xml %{pear_testdir}/%{pear_name} %{pear_phpdir}/Crypt - I would prefer using %{name}.xml rather than %{pear_name}.xml (see recently approved PHP Guidelines, this is usefull to avoid conflict between package from various channel) - a comment about running the tests (which must be done as root after install) will be usefull : => pear run-tests -p Crypt_Blowfish
Shouldn't this be renamed to php-pear-Crypt-Blowfish to meet Fedora package naming guidelines?
Yes Christopher, you're right, I've miss this error (but it's only first notes ;) not the formal review).
Renamed and updated to follow suggestions : Spec URL: http://www.bachelot.org/fedora/SPECS/php-pear-Crypt-Blowfish.spec SRPM URL: http://www.bachelot.org/fedora/SRPMS/php-pear-Crypt-Blowfish-1.1.0-0.2.rc2.fc10.src.rpm
You should remove (probably a paste error, already defined above) ---------------------------- BuildRequires: php-pear(PEAR) Requires: php-pear(PEAR) Requires(post): %{__pear} Requires(postun): %{__pear} Provides: php-pear(foo) = %{version} ----------------------------
REVIEW: + rpmlint is ok php-pear-Crypt-Blowfish.src: I: checking php-pear-Crypt-Blowfish.noarch: I: checking php-pear-Crypt-Blowfish.noarch: W: no-documentation 2 packages and 1 specfiles checked; 0 errors, 1 warnings. + package name + spec file name + package meet the PHP Guidelines + License ok : BSD + License is upstream + spec in english and legible + no license file in sources + sources match the upstream sources 09f0e38a4d524ba4102db5d11b07ffe9 Crypt_Blowfish-1.1.0RC2.tgz + Source URL ok + build / run on F10.x86_64 + BuildRequires (php-pear >= 1:1.4.9-1.2) ok + no locale + no .so + own all directories that it creates + no duplicate file + %defattr ok + %clean section + use macros consistently + contain code + no documentation + no devel + no pkgconfig + no sub-package + no GUI + don't own files or directories already owned by other packages + %install start with rm -rf + valid UTF-8 + build in mock (fedora-rawhide-x86_64) + test suite ok (2 PASSED TESTS) + scriptlets ok - Final Requires ok, but see previous comments - Final Provides ko, see previous comments php-pear(foo) = 1.1.0 Just fix the previous comment and I will approve this package.
Thanks for the review, Remi. This is indeed a cut and paste error... Fixed version : Spec URL: http://www.bachelot.org/fedora/SPECS/php-pear-Crypt-Blowfish.spec SRPM URL: http://www.bachelot.org/fedora/SRPMS/php-pear-Crypt-Blowfish-1.1.0-0.3.rc2.fc10.src.rpm
+ Requires php-pear(PEAR) + Provides php-pear(Crypt_Blowfish) = 1.1.0 php-pear-Crypt-Blowfish = 1.1.0-0.3.rc2.fc8 APPROVED
New Package CVS Request ======================= Package Name: php-pear-Crypt-Blowfish Short Description: Quick two-way blowfish encryption Owners: xavierb Branches: F-9 F-10 InitialCC:
cvs done.
php-pear-Crypt-Blowfish-1.1.0-0.3.rc2.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/php-pear-Crypt-Blowfish-1.1.0-0.3.rc2.fc10
Imported and built for F-10 and devel. Doesn't build on F-9 because php-pear version is too old (available 1.7.1, required 1.7.2)
php-pear-Crypt-Blowfish-1.1.0-0.3.rc2.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report.
Remi, the earlier 1.1.0 rc1 or 1.0.1 versions don't have a require on pear >= 1.7.2, this would allow to build for F9 and EL5. Would you object if I build either version ?
Package Change Request ====================== Package Name: php-pear-Crypt-Blowfish New Branches: EL-5 Owners: xavierb