Spec URL: http://allisson.fedorapeople.org/packages/perl-Net-DBus-GLib/perl-Net-DBus-GLib.spec SRPM URL: http://allisson.fedorapeople.org/packages/perl-Net-DBus-GLib/perl-Net-DBus-GLib-0.33.0-1.fc10.src.rpm Description: Net::DBus::GLib provides an extension to the Net::DBus module allowing integration with the GLib mainloop. To integrate with the main loop, simply get a connection to the bus via the methods in Net::DBus::GLib rather than the usual Net::DBus module. That's it - every other API remains the same.
Review: + package builds in mock (rawhide i386). koji Build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1141378 + rpmlint is silent for SRPM and for RPM. + source files match upstream url d86fac8abef6781e7f652b1062f474ff Net-DBus-GLib-0.33.0.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test gave All tests successful. Files=2, Tests=2, 0 wallclock secs ( 0.01 usr 0.01 sys + 0.25 cusr 0.03 csys = 0.30 CPU) + Package perl-Net-DBus-GLib-0.33.0-1.fc11 Provides: GLib.so perl(Net::DBus::GLib) = 0.33.0 Requires: libc.so.6 libc.so.6(GLIBC_2.1.3) libdbus-1.so.3 libdbus-glib-1.so.2 libglib-2.0.so.0 libgobject-2.0.so.0 perl(Glib) perl(Net::DBus) perl(strict) perl(warnings) rtld(GNU_HASH) Suggestions: 1)You should drop Net-DBus-GLib.spec file from installing in %doc 2)you can add examples directory in %doc 3)License for this package is of perl variant type "GPLv2+ or Artistic" APPROVED.
New Package CVS Request ======================= Package Name: perl-Net-DBus-GLib Short Description: Perl extension for the DBus GLib bindings Owners: allisson Branches: F-9 F-10
Please add InitialCC: perl-sig
New Package CVS Request ======================= Package Name: perl-Net-DBus-GLib Short Description: Perl extension for the DBus GLib bindings Owners: allisson Branches: F-9 F-10 InitialCC: perl-sig
cvs done.