Bug 486493 - Review Request: perl-Net-DBus-GLib - Perl extension for the DBus GLib bindings
Review Request: perl-Net-DBus-GLib - Perl extension for the DBus GLib bindings
Status: CLOSED NEXTRELEASE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Parag AN(पराग)
Fedora Extras Quality Assurance
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2009-02-19 18:43 EST by Allisson Azevedo
Modified: 2009-02-20 21:46 EST (History)
4 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2009-02-20 21:46:50 EST
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
panemade: fedora‑review+
kevin: fedora‑cvs+


Attachments (Terms of Use)

  None (edit)
Description Allisson Azevedo 2009-02-19 18:43:25 EST
Spec URL: http://allisson.fedorapeople.org/packages/perl-Net-DBus-GLib/perl-Net-DBus-GLib.spec

SRPM URL: http://allisson.fedorapeople.org/packages/perl-Net-DBus-GLib/perl-Net-DBus-GLib-0.33.0-1.fc10.src.rpm

Description: Net::DBus::GLib provides an extension to the Net::DBus module allowing
integration with the GLib mainloop. To integrate with the main loop, simply
get a connection to the bus via the methods in Net::DBus::GLib rather than
the usual Net::DBus module. That's it - every other API remains the same.
Comment 1 Parag AN(पराग) 2009-02-19 23:29:56 EST
Review:
+ package builds in mock (rawhide i386).
koji Build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1141378
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
d86fac8abef6781e7f652b1062f474ff  Net-DBus-GLib-0.33.0.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test gave
All tests successful.
Files=2, Tests=2,  0 wallclock secs ( 0.01 usr  0.01 sys +  0.25 cusr  0.03 csys =  0.30 CPU)
+ Package perl-Net-DBus-GLib-0.33.0-1.fc11
Provides:
 GLib.so
 perl(Net::DBus::GLib) = 0.33.0
Requires:
 libc.so.6
 libc.so.6(GLIBC_2.1.3)
 libdbus-1.so.3
 libdbus-glib-1.so.2
 libglib-2.0.so.0
 libgobject-2.0.so.0
 perl(Glib)
 perl(Net::DBus)
 perl(strict)
 perl(warnings)
 rtld(GNU_HASH)


Suggestions:
1)You should drop Net-DBus-GLib.spec file from installing in %doc
2)you can add examples directory in %doc
3)License for this package is of perl variant type "GPLv2+ or Artistic"


APPROVED.
Comment 2 Allisson Azevedo 2009-02-20 05:29:48 EST
New Package CVS Request
=======================
Package Name: perl-Net-DBus-GLib
Short Description: Perl extension for the DBus GLib bindings
Owners: allisson
Branches: F-9 F-10
Comment 3 Ralf Corsepius 2009-02-20 06:32:26 EST
Please add InitialCC: perl-sig
Comment 4 Allisson Azevedo 2009-02-20 07:25:40 EST
New Package CVS Request
=======================
Package Name: perl-Net-DBus-GLib
Short Description: Perl extension for the DBus GLib bindings
Owners: allisson
Branches: F-9 F-10
InitialCC: perl-sig
Comment 5 Kevin Fenzi 2009-02-20 15:22:04 EST
cvs done.

Note You need to log in before you can comment on or make changes to this bug.