Spec URL: http://dnielsen.fedorapeople.org/monsoon.spec SRPM URL: http://dnielsen.fedorapeople.org/monsoon-0.20-1.fc11.src.rpm Description: Monsoon is a Bittorrent client written in Mono and GTK#
Depends on Mono.Nat (review request #486557) and a MonoTorrent update to 0.70 (request #48558)
Created attachment 333395 [details] openSuse patch I found this patch in the openSuse package. Could you please investigate if we should include it too.
This is upstream and fixes a real bug (well actually it works around some Firefox strangeness) http://anonsvn.mono-project.com/viewvc/trunk/monsoon/Monsoon/TorrentController.cs?r1=125266&r2=127458 As such I would be willing to carry it in the package, I will add it along with any review changes or at import time. It can go away with the next release so the workload is acceptable and the user experience is improved.
- MUST: rpmlint must be run on every package. The output should be posted in the review. monsoon.i386: W: wrong-file-end-of-line-encoding /usr/share/doc/monsoon-0.20/COPYING monsoon.i386: E: no-binary monsoon.i386: E: only-non-binary-in-usr-lib Errors can be ignored but please see if you cansolve the warning. - MUST: The package must be named according to the Package Naming Guidelines OK - MUST: The spec file name must match the base package %{name}, in the format %{name}.spec OK - MUST: The package must meet the Packaging Guidelines. OK - MUST: The package must be licensed with a Fedora approved license and meet the Licensing Guidelines . OK - MUST: The License field in the package spec file must match the actual license. OK - MUST: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package must be included in %doc. OK - MUST: The spec file must be written in American English. OK - MUST: The spec file for the package MUST be legible. OK - MUST: The sources used to build the package must match the upstream source, as provided in the spec URL. Reviewers should use md5sum for this task. If no upstream URL can be specified for this package, please see the Source URL Guidelines for how to deal with this. OK - 1530450ee43d6103c063ea7d940854a9 - MUST: The package MUST successfully compile and build into binary rpms on at least one primary architecture. OK - i386 - MUST: If the package does not successfully compile, build or work on an architecture, then those architectures should be listed in the spec in ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug filed in bugzilla, describing the reason that the package does not compile/build/work on that architecture. The bug number MUST be placed in a comment, next to the corresponding ExcludeArch line. OK - MUST: All build dependencies must be listed in BuildRequires, except for any that are listed in the exceptions section of the Packaging Guidelines ; inclusion of those as BuildRequires is optional. Apply common sense. OK - MUST: A package must not contain any duplicate files in the %files listing. OK - MUST: Permissions on files must be set properly. Executables should be set with executable permissions, for example. Every %files section must include a %defattr(...) line. OK - MUST: Each package must have a %clean section, which contains rm -rf %{buildroot} (or $RPM_BUILD_ROOT). OK - MUST: Each package must consistently use macros. FAIL - use of %{buildroot} and $RPM_BUILD_ROOT - MUST: The package must contain code, or permissable content. OK - MUST: Packages must not own files or directories already owned by other packages. The rule of thumb here is that the first package to be installed should own the files or directories that other packages may rely upon. This means, for example, that no package in Fedora should ever share ownership with any of the files or directories owned by the filesystem or man package. If you feel that you have a good reason to own a file or directory that another package owns, then please present that at package review time. OK - MUST: At the beginning of %install, each package MUST run rm -rf %{buildroot} (or $RPM_BUILD_ROOT). OK - MUST: All filenames in rpm packages must be valid UTF-8. OK ############################################################ Some things left before you can upload the package in CVS: - Please correct the Url in URL field. - Please use %{buildroot} consistently (or $RPM_BUILD_ROOT) - Please add the patch. This are the only things left. I'm sure you going to correct this issues even if I approve it now. So: APPROVED
New Package CVS Request ======================= Package Name: monsoon Short Description: Monsoon is a Bittorrent client written in Mono and GTK# Owners: dnielsen Branches: F-9 F-10 InitialCC:
cvs done.
Monsoon is now in rawhide, F9 and F10 will follow as the required build deps make their way through bodhi.