Spec URL: http://people.parinux.org/~seyman/fedora/perl-CGI-Application/perl-CGI-Application.spec SRPM URL: http://people.parinux.org/~seyman/fedora/perl-CGI-Application/perl-CGI-Application-4.21-1.fc10.src.rpm Description: CGI::Application is an Object-Oriented Perl module which implements an Abstract Class. It is not intended that this package be instantiated directly. Instead, it is intended that your Application Module will be implemented as a Sub-Class of CGI::Application.
This is an unofficial review: - The build return errors complaining "Test::More is not installed". Should be part of the BuildRequires? OKAYs: - Checksum matches upstream (778ecbaf87bc3fe56df210841a80aa83eb64b78a26c4bd0079143705a1301be9 CGI-Application-4.21.tar.gz) - BuildRoot (%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)) - Licensing (GPL+ or Artistic, included in package) - Latest upstream version (4.21) - Rpmlint quiet - %clean, %install present and starts with "rm -rf $RPM_BUILD_ROOT" - file permission (-,root,root,-)
(In reply to comment #1) > > This is an unofficial review: Thanks for investing your time on this review, Suravee. It's very much appreciated. > - The build return errors complaining "Test::More is not installed". Should be > part of the BuildRequires? Correct. I've uploaded another release (4.21-2) which corrects this. Spec URL: http://people.parinux.org/~seyman/fedora/perl-CGI-Application/perl-CGI-Application.spec SRPM URL: http://people.parinux.org/~seyman/fedora/perl-CGI-Application/perl-CGI-Application-4.21-2.fc10.src.rpm
I do not see that you are in the packager group, so I have indicated that you need a sponsor.
k, taking the review and removing sponsor request block, i take care of that one.
Merging additional review block from comment #1 OK source files match upstream(double checked): 778ecbaf87bc3fe56df210841a80aa83eb64b78a26c4bd0079143705a1301be9 CGI-Application-4.21.tar.gz OK package meets naming and versioning guidelines. OK specfile is properly named, is cleanly written and uses macros consistently. OK dist tag is present. OK build root is correct. OK license field matches the actual license. OK License text included in package. OK latest version is being packaged (not mandatory). OK BuildRequires are proper and match PERL packaging Guideline. OK Build framework is used and correctly BR'ed. OK %clean is present. OK package builds in koji (Rawhide, f-10). OK rpmlint is silent. OK final provides and requires look good. OK %check is present and all tests pass. OK owns the directories it creates. OK doesn't own any directories it shouldn't. OK no duplicates in %files. OK file permissions are appropriate. OK documentation is small, so no -docs subpackage is necessary. That package is good for FPC. *APPROVED* Please, follow those steps below before request CVS branch and sponsorship. Sponsorship: https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group Once you get approved as a Fedora packager go to: https://fedoraproject.org/wiki/CVS_admin_requests I'd also like that you start review a couple of packages Review Requests to track down your skills and your understanding in Fedora rpm packaging's way.
New Package CVS Request ======================= Package Name: perl-CGI-Application Short Description: Framework for building reusable web-applications Owners: eseyman Branches: F-9 F-10 InitialCC: perl-sig
cvs done.
perl-CGI-Application-4.21-2.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/perl-CGI-Application-4.21-2.fc10
perl-CGI-Application-4.21-2.fc10 has been pushed to the Fedora 10 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update perl-CGI-Application'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F10/FEDORA-2009-3291
perl-CGI-Application-4.21-2.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report.
Package Change Request ====================== Package Name: perl-CGI-Application New Branches: el6 Owners: eseyman ktdreyer InitialCC: perl-sig Ken Dreyer contacted me for an el6 branch for this module.
Git done (by process-git-requests).