Bug 487196 - gnome-power-manager has hardcoded Requires: PolicyKit-gnome
Summary: gnome-power-manager has hardcoded Requires: PolicyKit-gnome
Keywords:
Status: CLOSED NOTABUG
Alias: None
Product: Fedora
Classification: Fedora
Component: gnome-power-manager
Version: rawhide
Hardware: All
OS: Linux
low
medium
Target Milestone: ---
Assignee: Richard Hughes
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2009-02-24 18:11 UTC by Kevin Kofler
Modified: 2009-02-27 23:28 UTC (History)
3 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2009-02-27 18:56:14 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Kevin Kofler 2009-02-24 18:11:41 UTC
Description of problem:
gnome-power-manager has a hardcoded dependency on PolicyKit-gnome. Is this really necessary? In the KDE spin, we would like to ship PolicyKit-kde instead of PolicyKit-gnome. PolicyKit-kde also implements the org.freedesktop.PolicyKit.AuthenticationAgent service.

(Note that gnome-power-manager is not included on the current KDE spin.)

Version-Release number of selected component (if applicable):
gnome-power-manager-0:2.25.91-1.fc11

How reproducible:
Always

Steps to Reproduce:
1. repoquery --repoid=rawhide --whatrequires PolicyKit-gnome
  
Actual results:
gnome-power-manager requires PolicyKit-gnome.

Expected results:
gnome-power-manager does not require PolicyKit-gnome.

Additional info:
Maybe a common Provides in both PolicyKit-gnome and PolicyKit-kde is needed?

Comment 1 Richard Hughes 2009-02-25 09:01:12 UTC
(In reply to comment #0)
> Maybe a common Provides in both PolicyKit-gnome and PolicyKit-kde is needed?

Sure, a provide of SessionAuthenticationAgent would probably be the best idea.

Comment 2 Kevin Kofler 2009-02-27 17:24:06 UTC
In Rawhide, both PolicyKit-gnome and PolicyKit-kde now have:
Provides: PolicyKit-authentication-agent
so you can require this instead of PolicyKit-gnome.

Comment 3 Matthias Clasen 2009-02-27 18:55:59 UTC
Actually, gnome-power-manager does use the PolicyKit-gnome bits:

        return polkit_gnome_action_create_button (prefs->priv->default_action);


So we wont get rid of the library dependency against PolicyKit-gnome here.

Comment 4 Kevin Kofler 2009-02-27 23:23:17 UTC
We can live with that one as well.

Comment 5 Kevin Kofler 2009-02-27 23:24:57 UTC
That said, isn't that stuff in PolicyKit-gnome-libs? If it is, we could still avoid dragging in the main package.

But gnome-power-manager isn't going to be used on the KDE spin either way.

Comment 6 Matthias Clasen 2009-02-27 23:28:47 UTC
I guess you are right about the -libs. 

Anyway, the package only has an explicit requires for PolicyKit-authentication-agent now.


Note You need to log in before you can comment on or make changes to this bug.