Bug 487539 - ruby: HTTP response splitting issue in CGI module
Summary: ruby: HTTP response splitting issue in CGI module
Keywords:
Status: CLOSED WONTFIX
Alias: None
Product: Security Response
Classification: Other
Component: vulnerability
Version: unspecified
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Red Hat Product Security
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2009-02-26 16:24 UTC by Tomas Hoger
Modified: 2019-09-29 12:28 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2011-06-01 07:01:24 UTC
Embargoed:


Attachments (Terms of Use)

Description Tomas Hoger 2009-02-26 16:24:42 UTC
HTTP response splitting issue was reported for Rails:
  http://weblog.rubyonrails.com/2008/10/19/response-splitting-risk

This issue was assigned CVE id CVE-2008-5189 and is tracked via bug #472510.

The underlying issue exists in the Ruby's CGI module.  Following patch was proposed for Ruby's CGI module:
  http://article.gmane.org/gmane.comp.lang.ruby.core/18709

It does not seem to have been committed upstream yet.

References:
http://bugs.gentoo.org/show_bug.cgi?id=242914

Comment 4 Vít Ondruch 2011-05-31 12:34:21 UTC
Hi guys,

I don't think this patch should be applied. 

* Upstream did not accepted the proposed patch and it is not in upstream [1]
* It breaks conformity to standard
* Neither Gentoo applied this patch as can be seen from link above
* Rails handles the issue.

So what actually is the reason to apply this patch?


[1] https://github.com/ruby/ruby/blob/trunk/lib/cgi/core.rb#L151

Comment 5 Huzaifa S. Sidhpurwala 2011-06-01 07:01:24 UTC
Hi Vit,

> So what actually is the reason to apply this patch?

Thanks for looking into this. Since upstream has decided to fix this in Rails and not in the ruby framework itself, we should do the same.

I am going to close this as a NOTABUG


Note You need to log in before you can comment on or make changes to this bug.