Red Hat Bugzilla – Bug 487645
Review Request: mediawiki-wikicalendar - Simple calendar extension for mediawiki
Last modified: 2009-03-04 02:24:57 EST
Spec URL: http://rpms.damian.net/SPECS/mediawiki-wikicalendar.spec SRPM URL: http://rpms.damian.net/SRPMS/mediawiki-wikicalendar-1.15-1.fc10.src.rpm Description: The extension adds an <calendar> tag to the mediawiki syntax which can show calendars in different formats. The idea was to keep the calendar as simple as possible and leave all the editing and page creation to mediawiki. It doesn't require any new database tables or files.
Review: + package builds in mock (rawhide i386). koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1204564 + rpmlint is silent for SRPM and for RPM. + source files match upstream. f99d5fa46be90862952e8f914e217f4d wikicalendar-1.15.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc files present. + BuildRequires are proper. + defattr usage is correct. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code. + no static libraries. + no .pc file present. + no -devel subpackage exists. + no .la files. + no translations are available. + Does owns the directories it creates. + no duplicates in %files. + file permissions are appropriate. + no scriptlets are used. + Not a GUI app. Suggestions: 1) License tag should be GPLv2+ APPROVED.
New Package CVS Request ======================= Package Name: mediawiki-wikicalendar Short Description: Simple calendar extension for mediawiki Owners: cdamian Branches: F-10 EL-5 InitialCC:
cvs done.
can you close this review now as packages are built in cvs?
closing now