Bug 487938 - Review Request: scheme2js - Scheme to JavaScript compiler
Summary: Review Request: scheme2js - Scheme to JavaScript compiler
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Peter Robinson
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2009-03-01 15:43 UTC by Michel Lind
Modified: 2009-03-25 16:07 UTC (History)
3 users (show)

Fixed In Version: 20081219-2.fc9
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2009-03-25 16:01:23 UTC
Type: ---
Embargoed:
pbrobinson: fedora-review+
kevin: fedora-cvs+


Attachments (Terms of Use)

Description Michel Lind 2009-03-01 15:43:55 UTC
Spec URL: http://salimma.fedorapeople.org/specs/funpl/scheme2js.spec
SRPM URL: http://salimma.fedorapeople.org/specs/funpl/scheme2js-20081219-1.fc10.src.rpm
Description:
Scheme2Js is a Scheme to JavaScript compiler distributed under the GPL
license. While some effort has been spent on being as close as
possible to R5RS, we concentrated mainly on efficiency. Usually
Scheme2Js produces JavaScript code, that is comparable to hand-written
code. In order to achieve this performance, Scheme2Js is not
completely R5RS compliant. In particular it lacks exact
numbers. Scheme2Js is not yet complete either: it lacks hygienic
macros and the eval procedure.

Comment 1 Peter Robinson 2009-03-02 21:10:11 UTC
I'll review this one.

Comment 2 Peter Robinson 2009-03-04 14:12:50 UTC
The build fails on PPC for some reason.
http://koji.fedoraproject.org/koji/taskinfo?taskID=1220304

Comment 3 Michel Lind 2009-03-04 23:07:05 UTC
Ah. Not PPC, PPC 64:

DEBUG util.py:256:  No Package Found for bigloo

Looks like bigloo is not available there yet. I'm ExcludeArch:-ing it, and will have to block the PPC64 tracker after this package enters Fedora.

http://salimma.fedorapeople.org/specs/funpl/scheme2js-20081219-2.fc11.src.rpm

Comment 4 Peter Robinson 2009-03-05 20:12:58 UTC
Almost done. There's just a single error for rpmlint that should probably be fixed.

+ rpmlint output

$ rpmlint -i scheme2js-20081219-2.fc11.src.rpm 
scheme2js.src:35: W: configure-without-libdir-spec
A configure script is run without specifying the libdir. configure options
must be augmented with something like --libdir=%{_libdir} whenever the script
supports it.

1 packages and 0 specfiles checked; 0 errors, 1 warnings.

+ package name satisfies the packaging naming guidelines
+ specfile name matches the package base name
+ package should satisfy packaging guidelines
+ license meets guidelines and is acceptable to Fedora
+ license matches the actual package license

+ %doc includes license file
+ spec file written in American English
+ spec file is legible
+ upstream sources match sources in the srpm
  efb16e806849ff0198a965b5d2d91b38  scheme2js-20081219.tar.gz

+ package successfully builds on at least one architecture
  tested using koji scratch build
+ BuildRequires list all build dependencies
n/a %find_lang instead of %{_datadir}/locale/*
n/a binary RPM with shared library files must call ldconfig in %post and %postun+ does not use Prefix: /usr
n/a package owns all directories it creates
n/a no duplicate files in %files
+ %defattr line
+ %clean contains rm -rf $RPM_BUILD_ROOT
+ consistent use of macros
+ package must contain code or permissible content
n/a large documentation files should go in -doc subpackage
+ files marked %doc should not affect package
n/a header files should be in -devel
n/a static libraries should be in -static
n/a packages containing pkgconfig (.pc) files need 'Requires: pkgconfig'
n/a libfoo.so must go in -devel
n/a devel must require the fully versioned base
n/a packages should not contain libtool .la files
n/a packages containing GUI apps must include %{name}.desktop file
+ packages must not own files or directories owned by other packages
+ %install must start with rm -rf %{buildroot} etc.
+ filenames must be valid UTF-8

Optional:

+ if there is no license file, packager should query upstream
n/a translations of description and summary for non-English languages, if
available
+ reviewer should build the package in mock/koji
+ the package should build into binary RPMs on all supported architectures
n/a review should test the package functions as described
+ scriptlets should be sane
n/a pkgconfig files should go in -devel
+ shouldn't have file dependencies outside /etc /bin /sbin /usr/bin or
/usr/sbin

Comment 5 Michel Lind 2009-03-05 20:42:37 UTC
Thanks. Regarding rpmlint, note that the configure script for scheme2js is not generated by autotools.

scheme2js gets most of its configuration flags from Bigloo, including optimization flags. libdir is not necessary, as the package does not contain any shared libraries.

On my x86_64 machine, scheme2js picks up libraries from lib64 just fine:
$ ldd /usr/bin/scheme2js
	linux-vdso.so.1 =>  (0x00007fff91bff000)
	libbigloo_s-3.1b.so => /usr/lib64/libbigloo_s-3.1b.so (0x000000000090f000)
	libbigloogc-3.1b.so => /usr/lib64/libbigloogc-3.1b.so (0x0000000000110000)
	libdl.so.2 => /lib64/libdl.so.2 (0x000000300e000000)
	libm.so.6 => /lib64/libm.so.6 (0x000000300dc00000)
	libgmp.so.3 => /usr/lib64/libgmp.so.3 (0x0000003017c00000)
	libc.so.6 => /lib64/libc.so.6 (0x000000300d800000)
	/lib64/ld-linux-x86-64.so.2 (0x000000300d400000)

Comment 6 Peter Robinson 2009-03-05 21:05:19 UTC
Doh. Of course it doesn't have libs so it doesn't mater. Too long a day!

APPROVED!

Comment 7 Michel Lind 2009-03-05 21:08:39 UTC
Many thanks!

New Package CVS Request
=======================
Package Name: scheme2js
Short Description: Scheme to JavaScript compiler
Owners: salimma
Branches: EL-5 F-9 F-10
InitialCC:

Comment 8 Kevin Fenzi 2009-03-07 17:20:58 UTC
cvs done.

Comment 9 Fedora Update System 2009-03-09 18:14:43 UTC
scheme2js-20081219-2.fc10 has been submitted as an update for Fedora 10.
http://admin.fedoraproject.org/updates/scheme2js-20081219-2.fc10

Comment 10 Fedora Update System 2009-03-09 18:14:48 UTC
scheme2js-20081219-2.fc9 has been submitted as an update for Fedora 9.
http://admin.fedoraproject.org/updates/scheme2js-20081219-2.fc9

Comment 11 Fedora Update System 2009-03-09 22:49:20 UTC
scheme2js-20081219-2.fc10 has been pushed to the Fedora 10 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update scheme2js'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F10/FEDORA-2009-2456

Comment 12 Fedora Update System 2009-03-09 23:06:46 UTC
scheme2js-20081219-2.fc9 has been pushed to the Fedora 9 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing-newkey update scheme2js'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F9/FEDORA-2009-2542

Comment 13 Fedora Update System 2009-03-25 16:01:13 UTC
scheme2js-20081219-2.fc10 has been pushed to the Fedora 10 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 14 Fedora Update System 2009-03-25 16:07:51 UTC
scheme2js-20081219-2.fc9 has been pushed to the Fedora 9 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.