Bug 488168 - Package Review: ibus-table-wubi
Summary: Package Review: ibus-table-wubi
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
low
medium
Target Milestone: ---
Assignee: Parag AN(पराग)
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 488010
Blocks: 484650
TreeView+ depends on / blocked
 
Reported: 2009-03-02 23:54 UTC by Caius Chance
Modified: 2010-01-13 05:02 UTC (History)
7 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2009-04-02 00:40:39 UTC
Type: ---
Embargoed:
panemade: fedora-review+
kevin: fedora-cvs+


Attachments (Terms of Use)

Description Caius Chance 2009-03-02 23:54:01 UTC
A split from ibus-table-chinese, which was sub-package of ibus-table.

Uploading srpm and spec.

Comment 2 Jens Petersen 2009-03-17 08:19:29 UTC
What about the license?

Comment 3 Jens Petersen 2009-03-18 06:43:25 UTC
ping?

Comment 5 Caius Chance 2009-03-27 04:06:51 UTC
Ad per discussion, wubi98 is removed. Please proceed package review:

http://cchance.fedorapeople.org/packaging/ibus-table-wubi.spec
http://cchance.fedorapeople.org/packaging/ibus-table-wubi-1.1.0.20090316-2.fc11.src.rpm

Thanks a lot.

Comment 7 Caius Chance 2009-03-27 07:08:06 UTC
SRPM URL: http://cchance.fedorapeople.org/packaging/ibus-table-wubi-1.1.0.20090327-1.fc11.src.rpm  
Spec URL: http://cchance.fedorapeople.org/packaging/ibus-table-wubi.spec
Description: A split from ibus-table-chinese, which was sub-package of ibus-table.

Comment 8 Parag AN(पराग) 2009-03-30 08:32:01 UTC
Review:
+ package builds in mock (rawhide i586).
koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1264871
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
8aa15f5b6d1b12068b22ff5e9639a277  ibus-table-wubi-1.1.0.20090327.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ BuildRequires are proper.
+ defattr usage is correct.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available.
+ Does owns the directories it creates.
+ ibus-table-createdb scriptlet used.
+ file permissions are appropriate.
+ Not a GUI App.  

Suggestions:
1) Change license to GPLv3+
2) Good if you preserve timestamp of svg file also. Use
make DESTDIR=%{buildroot} install INSTALL="install -p"

APPROVED.

Comment 9 Caius Chance 2009-03-31 04:47:25 UTC
Package Change Request
=======================
Package Name: ibus-table-wubi
Short Description: Wubi input method for ibus-table.
Owners: cchance
Branches: N/A (devel)
InitialCC:
Cvsextras Commits: yes

Comment 11 Jens Petersen 2009-03-31 11:31:32 UTC
cvs done with

 Package Name: ibus-table-wubi
 Short Description: Wubi input method for ibus-table
 Owners: cchance
 Branches: devel
 InitialCC: i18n-team

Comment 14 Caius Chance 2009-05-20 00:42:52 UTC
Package Change Request
======================
Package Name: ibus-table-wubi
New Branches: F-10
Owners: cchance

Comment 15 Kevin Fenzi 2009-05-20 05:37:43 UTC
cvs done.


Note You need to log in before you can comment on or make changes to this bug.