Spec URL: http://rayvd.fedorapeople.org/python-text_table/python-text_table.spec SRPM URL: http://rayvd.fedorapeople.org/python-text_table/python-text_table-0.02-1.el5.src.rpm Description: This module provides an interface to output simple ASCII tables. It is based on the perl module Text::SimpleTable.
looks build failed http://koji.fedoraproject.org/koji/taskinfo?taskID=1219378 and license from source looked like Artistic which is bad license. You should ask upstream to change license.
Interesting. I'll look into the Python 2.6 build failures (only was able to test it on RHEL5). It looked like GPL was listed as a license for this package -- although Artistic was there too. I'll ask upstream to clarify.
It looks like Artistic+GPL is allowed. I've emailed the author to find out if it's Artistic or Artistic+GPL and whether or not he can include something in the future to make that a little more clear.
I received the following from the author: > Hi Ray, > > I'm surprised anyone is actually using that code, it was just a quick > port. > > Since it was a port, I retained the same license as the original Perl > code out of fairness to the original authors. > > My understanding is that the Artistic license can be dual-licensed with > GPL without issues, so that is okay with me. > > Please feel free to add the same information to the package. > > Regards, > Swaroop My question is -- is this sufficient? Should I include this in a README file with the package to indicate the correct licensing? I don't know that upstream is interested in releasing a new version simply to address this. Let me know what you think. I'll read over the Fedora licensing guidelines as well to see if there's some instruction there. Thanks.
So the artistic license while not approved for Fedora in version 1.0, please note that the clarified artistic license and artistic 2.0 are OK. I downloaded the spec, and it's highly unclear what version of the licenses they're talking about. I would ask upstream to include license texts in the tarball.
I got some feedback on the packaging list[1] and as a result I've taken the following steps: 1. Updated the License field of this package to be GPL+ or Artistic 2. Included the text of the email sent to me by the author in the package as "LICENSE" I will email the author back and attempt to get clarification on an exact license version, and request a new tarball to be released with license information included. In the interim, I believe the steps I took above should be sufficient to allow the review to continue with the understanding that I will update the package when upstream has time to release a new tarball. Updated spec and SRPM's are here: http://rayvd.fedorapeople.org/python-text_table/python-text_table.spec http://rayvd.fedorapeople.org/python-text_table/python-text_table-0.02-2.el5.src.rpm Incidentally, this new release also resolves the build issue in koji. [1]: https://www.redhat.com/archives/fedora-packaging/2009-March/msg00005.html
Hi Parag; will you be doing the review on this package or should I clear the review flag?
I need to look into license issue again to cross verify whether license will be "GPL+ or Artistic" or anything else. As got busy with some other review and you need to see this package reviewed soon, I will better clear review flag. Thanks for looking into license issue.
I believe the license issue is sufficiently resolved. rpmlint says: python-text_table.noarch: E: non-executable-script /usr/lib/python2.6/site-packages/text_table.py 0644 This is the usual "starts with a shebang but isn't executable" problem. I still have no idea why python programmers do this. I don't particularly think it's a problem but you can sed out the shebang line if you like. python-text_table.noarch: E: description-line-too-long This module provides an interface to output simple ASCII tables. It is based on That goes right to 80 characters. That's really the only real problem I see, so I'll approve this and you can reflow the %description when you check in. * source files match upstream. sha256sum: e66bb3f653879b7799b7928b762bbba2fd086c17f3fc55891c92c796be9c5f48 text_table-0.02.tar.gz * package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * summary is OK. * description is OK. * dist tag is present. * build root is OK. * license field matches the actual license. * license is open source-compatible. * license text not included upstream. * latest version is being packaged. * BuildRequires are proper. * %clean is present. * package builds in mock (rawhide, x86_64). * package installs properly. X rpmlint has a valid complaint. * final provides and requires are sane: python-text_table = 0.02-2.fc11 = python(abi) = 2.6 * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no generically named files * code, not content. * documentation is small, so no -doc subpackage is necessary. * %docs are not necessary for the proper functioning of the package. APPROVED, just re-wrap the description. The package review process needs reviewers! If you haven't done any package reviews recently, please consider doing one.
Thanks Jason. I'll try to tackle some reviews soon to help you guys out. :-)
Alright, for the record, final spec and SRPM: http://rayvd.fedorapeople.org/python-text_table/python-text_table.spec http://rayvd.fedorapeople.org/python-text_table/python-text_table-0.02-3.el5.src.rpm New Package CVS Request ======================= Package Name: python-text_table Short Description: Simple Eyecandy ASCII Tables Owners: rayvd Branches: EL-4 EL-5 F-9 F-10 InitialCC:
cvs done.
python-text_table-0.02-2.fc9 has been submitted as an update for Fedora 9. http://admin.fedoraproject.org/updates/python-text_table-0.02-2.fc9
python-text_table-0.02-2.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/python-text_table-0.02-2.fc10
python-text_table-0.02-2.fc9 has been pushed to the Fedora 9 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing-newkey update python-text_table'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F9/FEDORA-2009-2816
python-text_table-0.02-2.fc10 has been pushed to the Fedora 10 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update python-text_table'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F10/FEDORA-2009-2836
python-text_table-0.02-2.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report.
python-text_table-0.02-2.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report.