spec: http://terjeros.fedorapeople.org/python-ptrace/python-ptrace.spec srpm: http://terjeros.fedorapeople.org/python-ptrace/python-ptrace-0.6-1.fc10.src.rpm koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=1221817 Description: python-ptrace is a debugger using ptrace written in Python.
Updated koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1221878
Review: + package builds in mock. Koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1222751 + rpmlint is silent for SRPM and for RPM. + source files match upstream. 510c8c005f373c3e079074c9720bacc9 python-ptrace-0.6.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc files present. + BuildRequires are proper. + defattr usage is correct. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code. + no static libraries. + no .pc file present. + no -devel subpackage exists. + no .la files. + no translations are available. + Does owns the directories it creates. + no duplicates in %files. + file permissions are appropriate. + no scriptlets are used. + Not a GUI app. + Package python-ptrace-0.6-1.fc11-i586 Provides: cptrace.so Requires: /usr/bin/python libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.1.3) libpthread.so.0 libpthread.so.0(GLIBC_2.0) libpython2.6.so.1.0 python(abi) = 2.6 rtld(GNU_HASH) Suggestions: 1) you can consider changing %define to %global though not mandatory. 2) you can change following line in %files from %doc doc examples to %doc doc/* examples => better remove doc named directory 3) remove unnecessary line #BuildRequires: mercurial python-nose subversion APPROVED.
Thanks! New Package CVS Request ======================= Package Name: python-ptrace Short Description: Debugger using ptrace written in Python Owners: terjeros Branches: F-9 F-10 InitialCC:
cvs done.
Imported, built and pushed to bodhi,