Spec URL: http://fedorapeople.org/~cweyl/review/perl-Text-Password-Pronounceable.spec SRPM URL: http://fedorapeople.org/~cweyl/review/perl-Text-Password-Pronounceable-0.28-1.fc10.src.rpm Description: This module generates pronuceable passwords, based the the English digraphs by D. Edwards. Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1222971 *rt-0.05
Review: + package builds in mock (rawhide i386). koji Build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1222971 + rpmlint is silent for SRPM and for RPM. + source files match upstream url d6db4130b2c8e66f5d18f2c79af9ff31 Text-Password-Pronounceable-0.28.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test gave All tests successful. Files=4, Tests=9, 0 wallclock secs ( 0.00 usr 0.01 sys + 0.16 cusr 0.04 csys = 0.21 CPU) + Package perl-Text-Password-Pronounceable-0.28-1.fc11-noarch => Provides: perl(Text::Password::Pronounceable) = 0.28 Requires: perl(Carp) perl(strict) perl(warnings) APPROVED.
New Package CVS Request ======================= Package Name: perl-Text-Password-Pronounceable Short Description: Generate pronounceable passwords Owners: cweyl Branches: F-9 F-10 devel InitialCC: perl-sig
cvs done.
Thanks for the review! :-)