Bug 489104 - Interpretation of %_sourcedir macro when installing src.rpms has changed
Summary: Interpretation of %_sourcedir macro when installing src.rpms has changed
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: rpm
Version: rawhide
Hardware: All
OS: Linux
low
medium
Target Milestone: ---
Assignee: Panu Matilainen
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2009-03-07 17:16 UTC by Jason Tibbitts
Modified: 2009-03-09 04:38 UTC (History)
4 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2009-03-08 10:05:07 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Jason Tibbitts 2009-03-07 17:16:19 UTC
I have had 
  %_topdir    /home/tibbs/work/rpm
  %_sourcedir %{_topdir}/%{name}-%{version}
in my ~/.rpmmacros for many years now, so installed src.rpms would unpack nicely  under work/rpm.  But this morning when I updated my rawhide machine to rpm-4.7.0-0.beta1.1.fc11.x86_64, this behavior changed oddly.

Now installing a src.rpm creates two directories, one having the name I would expect (but empty) and one literally having the name "%{name}-%{version}" containing the spec, tarball and such.

Please let me know if there's anything I can do to help debug this.

Comment 1 Panu Matilainen 2009-03-08 10:05:07 UTC
Ah, yeah - just a silly oversight from src.rpm installation code cleanup, thanks for reporting.

Fixed in rpm-4.7.0-0.beta1.2.fc11.

Comment 2 Jason Tibbitts 2009-03-08 14:50:40 UTC
I pulled the build from koji and this is indeed fixed.  Thanks!

Comment 3 Jason Tibbitts 2009-03-09 04:38:12 UTC
I'm not sure if it's related (and if it's not I'll happily open another ticket), but I note that when I do a simple rpmbuild -bs --nodeps I find, created in my %_topdir, two empty directories:
  BUILDROOT
  %{name}-%{version} (literally)

I think the creation of the BUILDROOT directory may have shown up with 4.6 (I noticed the directory a while back but never figured out what was creating it), but the latter directory is new with the 4.7 releases.

For reference, here's my complete ~/.rpmmacros:

%_topdir                                /home/tibbs/work/rpm
%_builddir                              /home/tibbs/work/tmp
%_unpackaged_files_terminate_build      1
%_missing_doc_files_terminate_build     1
%_rpmdir                                /home/tibbs/work/built-rpms
%_srcrpmdir                             /home/tibbs/work/source-rpms
%_rpmfilename              %%{NAME}-%%{VERSION}-%%{RELEASE}.%%{ARCH}.rpm

%_sourcedir                             %{_topdir}/%{name}-%{version}
%_specdir                               %{_sourcedir}

%_signature gpg
%_gpg_path /home/tibbs/.gnupg
%_gpg_name Jason Tibbitts <tibbs.edu>
%_gpgbin /usr/bin/true

%packager                           Jason Tibbitts <tibbs.edu>
%_query_all_fmt %%{name}-%%{version}-%%{release}.%%{arch}


Note You need to log in before you can comment on or make changes to this bug.