Spec URL: http://fedorapeople.org/~cweyl/review/perl-Parse-BACKPAN-Packages.spec SRPM URL: http://fedorapeople.org/~cweyl/review/perl-Parse-BACKPAN-Packages-0.34-1.fc10.src.rpm Description: The Comprehensive Perl Archive Network (CPAN) is a very useful collection of Perl code. However, in order to keep CPAN relatively small, authors of modules can delete older versions of modules to only let CPAN have the latest version of a module. BACKPAN is where these deleted modules are backed up. It's more like a full CPAN mirror, only without the deletions. This module provides an index of BACKPAN and some handy functions. The data is fetched from the net and cached for an hour. Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1230091 *rt-0.05
Review: + package builds in mock (rawhide i386). koji Build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1230091 + rpmlint is silent for SRPM and for RPM. + source files match upstream url 278a232a6b987e4ff0db45f5ac191f3f Parse-BACKPAN-Packages-0.34.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test gave Nothing. + Package perl-Parse-BACKPAN-Packages-0.34-1.fc11.noarch => Provides: perl(Parse::BACKPAN::Packages) = 0.34 perl(Parse::BACKPAN::Packages::Distribution) perl(Parse::BACKPAN::Packages::File) Requires: perl(App::Cache) perl(CPAN::DistnameInfo) perl(Compress::Zlib) perl(IO::File) perl(IO::Zlib) perl(LWP::UserAgent) perl(Parse::BACKPAN::Packages::Distribution) perl(Parse::BACKPAN::Packages::File) perl(base) perl(strict) perl(warnings) APPROVED.
New Package CVS Request ======================= Package Name: perl-Parse-BACKPAN-Packages Short Description: Provide an index of BACKPAN Owners: cweyl Branches: F-9 F-10 devel InitialCC: perl-sig
cvs done.
Thanks for the review! :-)