Bug 489337 - Review Request: leonidas-backgrounds - Leonidas desktop backgrounds
Review Request: leonidas-backgrounds - Leonidas desktop backgrounds
Status: CLOSED RAWHIDE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Jason Tibbitts
Fedora Extras Quality Assurance
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2009-03-09 11:42 EDT by Martin Sourada
Modified: 2009-03-11 15:02 EDT (History)
3 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2009-03-11 15:02:13 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
tibbs: fedora‑review+
kevin: fedora‑cvs+


Attachments (Terms of Use)

  None (edit)
Description Martin Sourada 2009-03-09 11:42:14 EDT
Spec URL: http://mso.fedorapeople.org/packages/rawhide/SPECS/leonidas-backgrounds.spec
SRPM URL: http://mso.fedorapeople.org/packages/rawhide/SRPMS/leonidas-backgrounds-10.92.1-1.fc11.src.rpm
Description: Desktop backgrounds for the F11 Leonidas theme.
Comment 1 Jason Tibbitts 2009-03-09 15:24:01 EDT
Is there a canonical upstream source for the tarball besides this package?  If so, could you make Source0: be a full URL to it, or provide (in comments) instructions for generating that tarball?  And if this is the canonical source, please indicate that in the spec.

Note to anyone else looking: /usr/share/backgrounds is provided by filesystem in F11, so it's not left unowned.

However, it looks like /usr/share/gnome-background-properties is unowned.  I'm not really sure what to do about it; several other *-backgrounds packages own it, so it wouldn't be unreasonable for this package to own it as well.

FYI, "cp -a" implies "-r".

X can't compare source files against upstream.
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
* description is OK.
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text included in package.
? latest version is being packaged.
* BuildRequires are proper (none).
* %clean is present.
* package builds in mock (rawhide, x86_64).
* package installs properly.
* rpmlint is silent.
* final provides and requires are sane:
   leonidas-backgrounds = 10.92.1-1.fc11
  =
   (none)

X /usr/share/gnome-background-properties is unowned.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no generically named files.
* acceptable content.
Comment 2 Martin Sourada 2009-03-09 15:49:32 EDT
(In reply to comment #1)
> Is there a canonical upstream source for the tarball besides this package?  If
> so, could you make Source0: be a full URL to it, or provide (in comments)
> instructions for generating that tarball?  And if this is the canonical source,
> please indicate that in the spec.
> 
Added a comment the that the canonical source is only in the srpm and a short notice how to get the images within the source tarbal.

> Note to anyone else looking: /usr/share/backgrounds is provided by filesystem
> in F11, so it's not left unowned.
> 
> However, it looks like /usr/share/gnome-background-properties is unowned.  I'm
> not really sure what to do about it; several other *-backgrounds packages own
> it, so it wouldn't be unreasonable for this package to own it as well.
> 
Somehow skipped my attention, I've checked only the /usr/share/backgrounds for some reason... This package now owns it as well.

> FYI, "cp -a" implies "-r".
> 
Thanks, removed the superfluous -r.

> X can't compare source files against upstream.
See above

> ? latest version is being packaged.
Its a version approved by the art team lead (Máirín Duffy)

> X /usr/share/gnome-background-properties is unowned.
See above

New SPEC: http://mso.fedorapeople.org/packages/rawhide/SPECS/leonidas-backgrounds.spec
New SRPM: http://mso.fedorapeople.org/packages/rawhide/SRPMS/leonidas-backgrounds-10.92.1-2.fc11.src.rpm
Comment 3 Jason Tibbitts 2009-03-09 17:40:36 EDT
Looks good now, thanks.

APPROVED
Comment 4 Martin Sourada 2009-03-09 17:49:59 EDT
New Package CVS Request
=======================
Package Name: leonidas-backgrounds
Short Description: Leonidas desktop backgrounds
Owners: mso
Branches: 
InitialCC:
Comment 5 Martin Sourada 2009-03-09 17:57:59 EDT
Thanks for the review :-)
Comment 6 Kevin Fenzi 2009-03-09 22:27:46 EDT
cvs done.
Comment 7 Martin Sourada 2009-03-11 15:02:38 EDT
Tagget for beta, so should be in rawhide within next compose.

Note You need to log in before you can comment on or make changes to this bug.