Spec URL: http://mso.fedorapeople.org/packages/rawhide/SPECS/leonidas-backgrounds.spec SRPM URL: http://mso.fedorapeople.org/packages/rawhide/SRPMS/leonidas-backgrounds-10.92.1-1.fc11.src.rpm Description: Desktop backgrounds for the F11 Leonidas theme.
Is there a canonical upstream source for the tarball besides this package? If so, could you make Source0: be a full URL to it, or provide (in comments) instructions for generating that tarball? And if this is the canonical source, please indicate that in the spec. Note to anyone else looking: /usr/share/backgrounds is provided by filesystem in F11, so it's not left unowned. However, it looks like /usr/share/gnome-background-properties is unowned. I'm not really sure what to do about it; several other *-backgrounds packages own it, so it wouldn't be unreasonable for this package to own it as well. FYI, "cp -a" implies "-r". X can't compare source files against upstream. * package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * summary is OK. * description is OK. * dist tag is present. * build root is OK. * license field matches the actual license. * license is open source-compatible. * license text included in package. ? latest version is being packaged. * BuildRequires are proper (none). * %clean is present. * package builds in mock (rawhide, x86_64). * package installs properly. * rpmlint is silent. * final provides and requires are sane: leonidas-backgrounds = 10.92.1-1.fc11 = (none) X /usr/share/gnome-background-properties is unowned. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no generically named files. * acceptable content.
(In reply to comment #1) > Is there a canonical upstream source for the tarball besides this package? If > so, could you make Source0: be a full URL to it, or provide (in comments) > instructions for generating that tarball? And if this is the canonical source, > please indicate that in the spec. > Added a comment the that the canonical source is only in the srpm and a short notice how to get the images within the source tarbal. > Note to anyone else looking: /usr/share/backgrounds is provided by filesystem > in F11, so it's not left unowned. > > However, it looks like /usr/share/gnome-background-properties is unowned. I'm > not really sure what to do about it; several other *-backgrounds packages own > it, so it wouldn't be unreasonable for this package to own it as well. > Somehow skipped my attention, I've checked only the /usr/share/backgrounds for some reason... This package now owns it as well. > FYI, "cp -a" implies "-r". > Thanks, removed the superfluous -r. > X can't compare source files against upstream. See above > ? latest version is being packaged. Its a version approved by the art team lead (Máirín Duffy) > X /usr/share/gnome-background-properties is unowned. See above New SPEC: http://mso.fedorapeople.org/packages/rawhide/SPECS/leonidas-backgrounds.spec New SRPM: http://mso.fedorapeople.org/packages/rawhide/SRPMS/leonidas-backgrounds-10.92.1-2.fc11.src.rpm
Looks good now, thanks. APPROVED
New Package CVS Request ======================= Package Name: leonidas-backgrounds Short Description: Leonidas desktop backgrounds Owners: mso Branches: InitialCC:
Thanks for the review :-)
cvs done.
Tagget for beta, so should be in rawhide within next compose.