Spec URL: http://rdieter.fedorapeople.org/pkg-reviews/qtscriptgenerator/qtscriptgenerator.spec SRPM URL: http://rdieter.fedorapeople.org/pkg-reviews/qtscriptgenerator/qtscriptgenerator-0.1.0-1.fc10.src.rpm Description: Qt Script Generator is a tool that generates Qt bindings for Qt Script. With the generated bindings you get access to substantial portions of the Qt API from within Qt Script. scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1235096
Spec URL: http://rdieter.fedorapeople.org/pkg-reviews/qtscriptgenerator/qtscriptgenerator.spec SRPM URL: http://rdieter.fedorapeople.org/pkg-reviews/qtscriptgenerator/qtscriptgenerator-0.1.0-2.fc10.src.rpm %changelog Fri Mar 20 2009 Rex Dieter <rdieter> 0.1.0-2 - qt-4.5.0-7 fixed wrt phonon, drop no_phonon patch Will issue new scratch build as soon as the fixed qt lands in koji buildroot.
Hello. This is needed for the next amarok release, right? I downloaded qt-4.5.0-8.fc11 (and the corresponding qt-devel, qt-x11) from koji and tried to build qtscriptgenerator against them with mock (rawhide). The build fails with ---------------------------------------------------------------------- cd qtscript_phonon/ && make -f Makefile make[1]: Entering directory `/builddir/build/BUILD/qtscriptgenerator-src-0.1.0/qtbindings/qtscript_phonon' make -f Makefile.Release make[2]: Entering directory `/builddir/build/BUILD/qtscriptgenerator-src-0.1.0/qtbindings/qtscript_phonon' make[2]: *** No rule to make target `../../generated_cpp/com_trolltech_qt_phonon/main.cpp', needed by `release/main.o'. Stop. make[2]: Leaving directory `/builddir/build/BUILD/qtscriptgenerator-src-0.1.0/qtbindings/qtscript_phonon' make[1]: *** [release] Error 2 make[1]: Leaving directory `/builddir/build/BUILD/qtscriptgenerator-src-0.1.0/qtbindings/qtscript_phonon' make: *** [sub-qtscript_phonon-make_default] Error 2 --------------------------------------------------------------------- It looks like there's something wrong. Do I need to download anything else from koji?
odd, it built for me locally, I'll try a new scratch build.
In the meantime, you could try http://rdieter.fedorapeople.org/pkg-reviews/qtscriptgenerator/qtscriptgenerator-0.1.0-1.fc10.src.rpm which omits the problematic phonon bits.
%changelog * Mon Mar 23 2009 Rex Dieter <rdieter> 0.1.0-3 - BR: phonon-devel Spec URL: http://rdieter.fedorapeople.org/pkg-reviews/qtscriptgenerator/qtscriptgenerator.spec SRPM URL: http://rdieter.fedorapeople.org/pkg-reviews/qtscriptgenerator/qtscriptgenerator-0.1.0-3.fc10.src.rpm Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1253957
%changelog * Mon Mar 23 2009 Rex Dieter <rdieter> 0.1.0-4 - include qsexec Spec URL: http://rdieter.fedorapeople.org/pkg-reviews/qtscriptgenerator/qtscriptgenerator.spec SRPM URL: http://rdieter.fedorapeople.org/pkg-reviews/qtscriptgenerator/qtscriptgenerator-0.1.0-4.fc10.src.rpm Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1254267
Package Review ============== Key: - = N/A x = Check ! = Problem ? = Not evaluated === REQUIRED ITEMS === [x] Package is named according to the Package Naming Guidelines. [x] Spec file name must match the base package %{name}, in the format %{name}.spec. [x] Package meets the Packaging Guidelines. [x] Package successfully compiles and builds into binary rpms on at least one supported architecture. Tested on: builds in Koji [x] Rpmlint output: - W: devel-file-in-non-devel-package these are only symlinks, so I think it's OK [-] Package is not relocatable. [x] Buildroot is correct [x] Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x] License field in the package spec file matches the actual license. License type: GPLv2 [x] If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x] Spec file is legible and written in American English. [x] Sources used to build the package matches the upstream source, as provided in the spec URL. [x] All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [-] The spec file handles locales properly. [-] ldconfig called in %post and %postun if required. [x] Package must own all directories that it creates. [x] Package does not contain duplicates in %files. [x] Permissions on files are set properly. [x] Package has a %clean section, which contains rm -rf %{buildroot} (or $RPM_BUILD_ROOT). [x] Package consistently uses macros. [?] Large documentation files are in a -doc subpackage, if required. [-] Package uses nothing in %doc for runtime. [-] Header files in -devel subpackage, if present. [-] Static libraries in -devel subpackage, if present. [-] Package requires pkgconfig, if .pc files are present. [-] Development .so files in -devel subpackage, if present. [x] Package does not contain any libtool archives (.la). [-] Package contains a properly installed %{name}.desktop file if it is a GUI application. [x] Package does not own files or directories owned by other packages. === SUGGESTED ITEMS === [x] Package does not include license text files separate from upstream. [-] Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x] Reviewer should test that the package builds in koji. - http://koji.fedoraproject.org/koji/taskinfo?taskID=1254267 [x] Package should compile and build into binary rpms on all supported architectures. - http://koji.fedoraproject.org/koji/taskinfo?taskID=1254267 [x] Package functions as described. [-] Scriptlets must be sane, if used. [-] The placement of pkgconfig(.pc) files are correct. [-] File based requires are sane. === SUMMARY === - package name: qtscriptgenerator? these are already generated bindings - so maybe better name is qtscriptbindings or similar? - documentation and examples should be packaged
%changelog * Tue Mar 24 2009 Rex Dieter <rdieter> 0.1.0-5 - qtscriptgenerator/qtscriptbindings pkgs - qtscriptbindings: include docs, examples Spec URL: http://rdieter.fedorapeople.org/pkg-reviews/qtscriptgenerator/qtscriptgenerator.spec SRPM URL: http://rdieter.fedorapeople.org/pkg-reviews/qtscriptgenerator/qtscriptgenerator-0.1.0-5.fc10.src.rpm
Adjusting summary to match new spec
Two comments: - qsexec could/should be in qtscriptgenerator package - the same with README and README.qsexec (maybe LICENSE.GPL too as it applies for generator, not bindings?)
I thought about keeping qsexec along with the bindings, but I'm ok either way. Licensing... I attached it to the pkg lowest in the stack (qtscriptgenerator currently Requires: qtscriptbindings). Again, I'm ok either way. Any remaining review blockers? (that other stuff can be modified post-review, no?)
It's OK for me now, so APPROVED
Thanks. New Package CVS Request ======================= Package Name: qtscriptgenerator Short Description: A tool to generate Qt bindings for Qt Script Owners: rdieter Branches: F-9 F-10
cvs done.
imported
qtscriptgenerator-0.1.0-5.fc9 has been submitted as an update for Fedora 9. http://admin.fedoraproject.org/updates/qtscriptgenerator-0.1.0-5.fc9
qtscriptgenerator-0.1.0-5.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/qtscriptgenerator-0.1.0-5.fc10
qtscriptgenerator-0.1.0-5.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report.
qtscriptgenerator-0.1.0-5.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report.