Spec URL: http://silassewell.googlecode.com/svn/trunk/projects/packages/rpms/python-ftpdlib/python-ftpdlib.spec SRPM URL: http://silassewell.googlecode.com/files/python-ftpdlib-0.5.1-2.src.rpm Description: Python FTP server library provides a high-level portable interface to easily write asynchronous FTP servers with Python. Based on asyncore framework pyftpdlib is currently the most complete RFC-959 FTP server implementation available for Python programming language. I'll need a sponsor.
SRPM: http://silassewell.googlecode.com/files/pyftpdlib-0.5.1-3.fc10.src.rpm SPEC: http://silassewell.googlecode.com/svn/trunk/projects/packages/rpms/pyftpdlib/pyftpdlib.spec Diff: http://code.google.com/p/silassewell/source/diff?spec=svn201&r=201&format=side&path=/trunk/projects/packages/rpms/pyftpdlib/pyftpdlib.spec
Some notes: * Documents - Usually "INSTALL" is for people who want to install software by themselves and not needed for people using rpm. And for this package, this "INSTALL" file shows no information. * %defattr - %defattr(644, root, root, 755) is the same as %defattr(-.root,root,-), so this can be removed * rpmlint ---------------------------------------------------------- pyftpdlib.noarch: E: non-executable-script /usr/lib/python2.6/site-packages/pyftpdlib/ftpserver.py 0644 pyftpdlib.noarch: W: doc-file-dependency /usr/share/doc/pyftpdlib-0.5.1/demo/tls_ftpd.py /usr/bin/env pyftpdlib.noarch: W: doc-file-dependency /usr/share/doc/pyftpdlib-0.5.1/test/test_ftpd.py /usr/bin/env pyftpdlib.noarch: W: doc-file-dependency /usr/share/doc/pyftpdlib-0.5.1/demo/unix_ftpd.py /usr/bin/env pyftpdlib.noarch: W: doc-file-dependency /usr/share/doc/pyftpdlib-0.5.1/demo/md5_ftpd.py /usr/bin/env pyftpdlib.noarch: W: doc-file-dependency /usr/share/doc/pyftpdlib-0.5.1/demo/winnt_ftpd.py /usr/bin/env pyftpdlib.noarch: W: doc-file-dependency /usr/share/doc/pyftpdlib-0.5.1/demo/basic_ftpd.py /usr/bin/env pyftpdlib.noarch: W: doc-file-dependency /usr/share/doc/pyftpdlib-0.5.1/demo/throttled_ftpd.py /usr/bin/env ---------------------------------------------------------- - For non-executable-script warning: If this script can be executed directly by users, then this script should have executable permission (i.e. 0755). Otherwise (i.e. if this script is to be called from other program), then the shebang on this script should be removed. This script has __main__ so it seems that this script should have 0755 permission. - About doc-file-dependency This warnings can be removed by explicitly changing permissions under demo/ and test/ directory to 0644 at %prep, like: ---------------------------------------------------------- %prep %setup -q find demo/ test/ -type f | xargs chmod 0644 ----------------------------------------------------------
SRPM: http://silassewell.googlecode.com/files/pyftpdlib-0.5.1-4.fc10.src.rpm Diff: http://code.google.com/p/silassewell/source/diff?spec=svn209&r=209&format=side&path=/trunk/projects/packages/rpms/pyftpdlib/pyftpdlib.spec
Well, - As far as I am correct, only ftpserver.py needs executable permission and usually .py{o,c} have 0644 permission. Other things are okay. ------------------------------------------------------------ This package (pyftpdlib) is APPROVED by mtasaka ------------------------------------------------------------
I checked and you are correct, I fixed it in the SPEC/SRPM.
New Package CVS Request ======================= Package Name: pyftpdlib Short Description: Python FTP server library Owners: silas Branches: InitialCC:
cvs done.
Built for F-11, closing. Thanks Mamoru and Kevin.