Bug 490204 (mingw32-qt-qmake) - Review Request: mingw32-qt-qmake - build environment for Qt for MinGW applications
Summary: Review Request: mingw32-qt-qmake - build environment for Qt for MinGW applica...
Keywords:
Status: CLOSED NEXTRELEASE
Alias: mingw32-qt-qmake
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Richard W.M. Jones
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: mingw32-qt
TreeView+ depends on / blocked
 
Reported: 2009-03-13 19:48 UTC by Thomas Sailer
Modified: 2009-03-16 03:10 UTC (History)
4 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2009-03-16 03:10:11 UTC
Type: ---
Embargoed:
rjones: fedora-review+
kevin: fedora-cvs+


Attachments (Terms of Use)

Description Thomas Sailer 2009-03-13 19:48:57 UTC
Spec URL: http://sailer.fedorapeople.org/mingw32-qt-qmake.spec
SRPM URL: http://sailer.fedorapeople.org/mingw32-qt-qmake-4.5.0-1.fc11.src.rpm
Description:
MinGW Qt library Build Environment (qmake config).

Approved MinGW packaging guidelines are here:
http://fedoraproject.org/wiki/Packaging/MinGW

It has been suggested in bug #490132 that the qmake config files, which are installed to %{_libdir}, should be factored out into a separate package, to keep the huge mingw32-qt noarch. This is the factored-out package.

Comment 1 Richard W.M. Jones 2009-03-13 19:53:40 UTC
Taking for review.

Comment 2 Richard W.M. Jones 2009-03-13 19:54:49 UTC
auto-buildrequires looks OK:

BuildRequires: binutils = 2.19.51.0.2.16.fc11.x86_64
BuildRequires: coreutils = 7.1.6.fc11.x86_64
BuildRequires: diffutils = 2.8.1.23.fc11.x86_64
BuildRequires: findutils = 1:4.4.0.2.fc11.x86_64
BuildRequires: grep = 2.5.3.4.fc11.x86_64
BuildRequires: mingw32-filesystem = 49.3.fc11.noarch
BuildRequires: sed = 4.1.5.12.fc11.x86_64

Comment 3 Richard W.M. Jones 2009-03-13 19:56:04 UTC
rpmlint says:

mingw32-qt-qmake.x86_64: W: no-documentation

Consider adding %doc, although I won't disapprove the review
for lack of this.

mingw32-qt-qmake.x86_64: E: devel-dependency qt-devel

This is OK.

mingw32-qt-qmake.x86_64: E: no-binary

Also OK.

mingw32-qt-qmake.x86_64: E: only-non-binary-in-usr-lib

Also OK (in this case).

Comment 4 Richard W.M. Jones 2009-03-13 19:58:01 UTC
This is an extremely simple package which just installs
two %{SOURCE*} files into a specific location, as required
by the mingw32-qt.noarch package.

The package complies with Fedora packaging guidelines, and
is APPROVED by rjones.

Comment 5 Thomas Sailer 2009-03-13 20:05:00 UTC
New Package CVS Request
=======================
Package Name: mingw32-qt-qmake
Short Description: Qt for MinGW32 Build Environment
Owners: sailer rjones
Branches: 
InitialCC:

Comment 6 Thomas Sailer 2009-03-13 20:06:25 UTC
Thanks!

Hm, what documentation would you expect? I'm having troubles coming up with reasonable documentation for this package...

Or should I put an AUTHORS file in there containing RMW Jones? :)

Comment 7 Richard W.M. Jones 2009-03-13 20:18:26 UTC
Normally you'd just put a license file there.

I "wrote" this, but in fact I derived it from existing files
in the Qt distribution, so the correct way to do this is to
add the license file from Qt here.

Comment 8 Kevin Fenzi 2009-03-16 02:00:19 UTC
cvs done.

Comment 9 Thomas Sailer 2009-03-16 03:10:11 UTC
License file put into the package, and built for rawhide.


Note You need to log in before you can comment on or make changes to this bug.