Bug 490520 - Review Request: ioport - Access I/O ports
Summary: Review Request: ioport - Access I/O ports
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Marcela Mašláňová
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2009-03-16 19:44 UTC by Richard W.M. Jones
Modified: 2009-03-23 15:57 UTC (History)
2 users (show)

Fixed In Version: 1.2-1.fc10
Clone Of:
Environment:
Last Closed: 2009-03-23 11:33:03 UTC
Type: ---
Embargoed:
mmaslano: fedora-review+
kevin: fedora-cvs+


Attachments (Terms of Use)

Description Richard W.M. Jones 2009-03-16 19:44:38 UTC
Spec URL: http://www.annexia.org/tmp/ioport.spec
SRPM URL: http://et.redhat.com/~rjones/ioport/files/ioport-1.1-1.src.rpm
Description: 

These commands enable command line and script access directly to I/O
ports on PC hardware.

The inb, inw and inl commands perform an input (read) operation on the
given I/O port, and print the result.

The outb, outw and outl commands perform an output (write) operation
to the given I/O port, sending the given data.  Note that the order of
the parameters is ADDRESS DATA.

The size of the operation is selected according to the suffix, with
'b' meaning byte, 'w' meaning word (16 bits) and 'l' meaning long
(32 bits).

Comment 1 Richard W.M. Jones 2009-03-16 19:45:04 UTC
Koji scratch build:

http://koji.fedoraproject.org/koji/taskinfo?taskID=1244739

Comment 2 Richard W.M. Jones 2009-03-16 19:45:34 UTC
rpmlint is silent.

Comment 3 Marcela Mašláňová 2009-03-18 08:49:41 UTC
OK Rpmlint must be run on every package.
OK The package must be named according to the Package Naming Guidelines.
OK The spec file name must match the base package %{name}.
OK The package must meet the Packaging Guidelines.
OK The package must be licensed with a Fedora approved license.
OK The License field in the package spec file must match the actual license.
OK If (and only if) the source package includes the text of the license(s) in its own file.
OK The spec file must be written in American English.
OK The spec file for the package MUST be legible.
OK The sources used to build the package must match the upstream source.
        5b76f5d5bcafa2dafb6001b9ac40a7e8
OK The package MUST successfully compile.
OK Correct BuildRequires.
OK Proper use of %find_lang macro. Using %{_datadir}/locale/* is strictly forbidden.
OK Shared library files (not just symlinks) must call ldconfig in %post and %postun.
OK Relocatable package must state this fact in the request for review.
OK A package must own all directories that it creates.
OK A package must not contain any duplicate files in the %files listing.
OK Permissions on files must be set properly.
OK Each package must have a %clean section, which contains rm -rf %{buildroot} (or $RPM_BUILD_ROOT).
OK Each package must consistently use macros.
OK The package must contain code, or permissable content.
OK Large documentation files must go in a -doc subpackage.
OK If a package includes something as %doc, it must not affect the runtime of the application.
OK Header files must be in a -devel package.
OK Static libraries must be in a -static package.
OK Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig'.
OK Library files with a suffix (e.g. libfoo.so.1.1) and files that end in .so (without suffix) must go in -devel.
OK In the vast majority of cases, devel packages must require the base package.
OK Packages must NOT contain any .la libtool archives.
OK Packages containing GUI applications must include a %{name}.desktop file.
OK At the beginning of %install, each package MUST run rm -rf %{buildroot} (or $RPM_BUILD_ROOT).

In the spec is missing dist tag. Please add it before build.
ACCEPTED

Comment 4 Richard W.M. Jones 2009-03-18 09:10:31 UTC
Thanks!  That was quick.  I will add the %{?dist} tag
to my local build so it'll go in when I import.

Comment 5 Richard W.M. Jones 2009-03-18 09:15:28 UTC
New Package CVS Request
=======================
Package Name: ioport
Short Description: Access I/O ports
Owners: rjones
Branches: F-10
InitialCC:

Comment 6 Kevin Fenzi 2009-03-20 02:55:42 UTC
cvs done.

Comment 7 Richard W.M. Jones 2009-03-23 11:33:03 UTC
Imported into Rawhide & F-10.

Comment 8 Fedora Update System 2009-03-23 11:34:23 UTC
ioport-1.2-1.fc10 has been submitted as an update for Fedora 10.
http://admin.fedoraproject.org/updates/ioport-1.2-1.fc10

Comment 9 Fedora Update System 2009-03-23 15:57:34 UTC
ioport-1.2-1.fc10 has been pushed to the Fedora 10 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.