Spec URL: http://maxamillion.fedorapeople.org/ninvaders.spec SRPM URL: http://maxamillion.fedorapeople.org/ninvaders-0.1.1-1.src.rpm Description: Ever wanted to place space invaders when you can't find a GUI? Now you can! ninvaders is a ncurses based space invaders clone to play from the command line
I'll do the review.
rpmlint output: ninvaders.x86_64: W: file-not-utf8 /usr/share/doc/ninvaders-0.1.1/ChangeLog 3 packages and 0 specfiles checked; 0 errors, 1 warnings. - Fix the rpmlint warning with iconv -f iso-8859-1 -t utf8 ChangeLog > ChangeLog.new && \ touch -r ChangeLog ChangeLog.new && mv ChangeLog.new ChangeLog - Change buildroot to the Guideline's recommended version %(mktemp -ud %{_tmppath}/%{name}-%{version}-%{release}-XXXXXX) - Remove Requires: ncurses as this is automatically picked up by rpmbuild. - Add trailing period to %description - Enable smp make with make %{?_smp_mflags} - Is there a reason why you change the name of the binary? I think you should keep it consistent with upstream...
Spec URL: http://maxamillion.fedorapeople.org/ninvaders.spec SRPM URL: http://maxamillion.fedorapeople.org/ninvaders-0.1.1-2.src.rpm I have fixed all that was mentioned. I also went ahead and changed the name of the binary back to upstream. It was purely a preference choice but I do agree that keeping synchronized with upstream is a better idea. Thank you for your time, looking forward to further review. :)
rpmlint output is clean. The package adheres to the Fedora Packaging and Package review Guidelines and is thus APPROVED.
New Package CVS Request ======================= Package Name: ninvaders Short Description: Space Invaders clone written in ncurses for cli gaming Owners: maxamillion Branches: F-9 F-10 EL-4 EL-5 InitialCC:
cvs done.
ninvaders-0.1.1-2.fc9 has been submitted as an update for Fedora 9. http://admin.fedoraproject.org/updates/ninvaders-0.1.1-2.fc9
ninvaders-0.1.1-2.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/ninvaders-0.1.1-2.fc10
ninvaders-0.1.1-2.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report.
ninvaders-0.1.1-2.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report.