Bug 491264 - kernel-rt should be built with -fwrapv [mrg-1]
Summary: kernel-rt should be built with -fwrapv [mrg-1]
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise MRG
Classification: Red Hat
Component: realtime-kernel
Version: 1.1
Hardware: All
OS: Linux
high
high
Target Milestone: 1.1.3
: ---
Assignee: Red Hat Real Time Maintenance
QA Contact: David Sommerseth
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2009-03-20 06:25 UTC by Eugene Teo (Security Response)
Modified: 2016-05-22 23:28 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2009-06-03 15:37:11 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)
Upstream patch (1.25 KB, patch)
2009-03-20 06:28 UTC, Eugene Teo (Security Response)
no flags Details | Diff


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHSA-2009:1081 0 normal SHIPPED_LIVE Important: kernel-rt security and bug fix update 2009-06-03 15:36:49 UTC

Description Eugene Teo (Security Response) 2009-03-20 06:25:28 UTC
Description of problem:
Add '-fwrapv' to gcc CFLAGS. This makes sure that gcc doesn't try to optimize away wrapping arithmetic, which the kernel occasionally uses for overflow testing, ie things like

if (ptr + offset < ptr)

which technically is undefined for non-unsigned types. See

http://bugzilla.kernel.org/show_bug.cgi?id=12597

for details.

Not all versions of gcc support it, so we need to make it conditional (it looks like it was introduced in gcc-3.4).

Comment 5 David Sommerseth 2009-05-26 14:32:03 UTC
Verified by code review.  Upstream patch (attached here) found in 2.6.24.7-117.el5rt source tree.

Comment 7 errata-xmlrpc 2009-06-03 15:37:11 UTC
An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on therefore solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHSA-2009-1081.html


Note You need to log in before you can comment on or make changes to this bug.