Bug 491821 - Review Request: hyphen-hsb - Upper Sorbian hyphenation rules
Summary: Review Request: hyphen-hsb - Upper Sorbian hyphenation rules
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Parag AN(पराग)
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
: 491822 (view as bug list)
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2009-03-24 09:56 UTC by Caolan McNamara
Modified: 2009-03-28 16:02 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2009-03-28 16:02:59 UTC
Type: ---
Embargoed:
panemade: fedora-review+
kevin: fedora-cvs+


Attachments (Terms of Use)

Description Caolan McNamara 2009-03-24 09:56:45 UTC
Spec URL: http://people.redhat.com/caolanm/rpms/hyphen-hsb.spec
SRPM URL: http://people.redhat.com/caolanm/rpms/hyphen-hsb-0.20080619-1.fc10.src.rpm
Description: Upper Sorbian hyphenation rules

Comment 1 Parag AN(पराग) 2009-03-24 10:32:35 UTC
*** Bug 491822 has been marked as a duplicate of this bug. ***

Comment 2 Caolan McNamara 2009-03-24 10:43:15 UTC
See bug 490862 for COPYING i.e. "relicense the file as LPPL 1.3a and include a copy of the email as %doc"

Comment 3 Parag AN(पराग) 2009-03-25 04:32:42 UTC
Review:
+ package builds in mock (rawhide i586).
koji Build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1257572
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
72dee9bee45d94b0e73d5e1a0c06a27c  hyph-hsb.tex
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.

APPROVED.

Comment 4 Caolan McNamara 2009-03-25 09:23:26 UTC
New Package CVS Request
=======================
Package Name: hyphen-hsb
Short Description: Upper Sorbian hyphenation rules
Owners: caolanm
Branches: devel
InitialCC:

Comment 5 Kevin Fenzi 2009-03-27 20:16:07 UTC
cvs done.


Note You need to log in before you can comment on or make changes to this bug.