Spec URL: http://rezza.hofyland.cz/fedora/packages/kde-style-skulpture/kde-style-skulpture.spec SRPM URL: http://rezza.hofyland.cz/fedora/packages/kde-style-skulpture/kde-style-skulpture-0.2.2-1.fc10.src.rpm Description: Skulpture is a GUI style addon for KDE 4. It features a classical three-dimensional artwork with shadows and smooth gradients to enhance the visual experience. Skulpture has been designed to be light and easy on eyes; many distracting borders or graphical elements have been removed or replaced by simpler artwork.
This is my first review, and I'm using this guide: http://fedoraproject.org/wiki/Packaging/ReviewGuidelines#Things_To_Check_On_Review Points to Check on: * package did NOT build on PPC. Please see http://koji.fedoraproject.org/koji/getfile?taskID=1260790&name=build.log for more details * Is it possible to use %_qt4_plugindir rather than '%define qtplugindir %(qmake-qt4 -query QT_INSTALL_PLUGINS)' Mandatory Tests: * rpmlint passes with no errors or warnings: $ rpmlint SRPMS/kde-style-skulpture-0.2.2-1.fc10.src.rpm RPMS/i386/kde-style-skulpture-0.2.2-1.fc10.i386.rpm RPMS/i386/kde-style-skulpture-debuginfo-0.2.2-1.fc10.i386.rpm SPECS/kde-style-skulpture.spec 3 packages and 1 specfiles checked; 0 errors, 0 warnings. * package is named as per Package Naming Guidelines * spec filename matched name * Package meets Packaging Guidelines * Package is GPLv3 licensed * License verified in COPYING file * %doc includes Copying * spec in american english * specfile is legible * sources match the upstream * package compiles on (at least i386) * no ExcludeArch * all dependencies listed * no locales (not needed as this is a theme) * package is not relocatable * package does creates one directory. It uses directories from kde-filesystem (which it depends on implicitly) * no file is listed more than once * permissions correctly set * clean section is correct * package consistently uses macros * package contains only code * no doc subpackage required * %doc files are optional * no header files present, so no -devel package * no static subpackage needed * no pkgconfig files * no library files with a suffix * no -devel package * no .la libtool archives present * package is not a gui application, so need not run desktop-file-install * package does not own files owned by other packages * %install runs rm -rf %{buildroot} * package is UTF-8 valid Optional Items: * Source package contains a COPYING file * No translations in spec file * Package does NOT build on all architecture: http://koji.fedoraproject.org/koji/taskinfo?taskID=1260789 Package fails to build on PPC architecture * Package runs as advertises, and stlye resembles the screenshot upstream * no scriptlets used * no subpackages * no pkgconfig files * package has no file dependencies
Spec URL: http://rezza.hofyland.cz/fedora/packages/kde-style-skulpture/kde-style-skulpture.spec SRPM URL: http://rezza.hofyland.cz/fedora/packages/kde-style-skulpture/kde-style-skulpture-0.2.2-3.fc10.src.rpm - uses _qt4_plugindir - ExcludeArch ppc for Fedora <= 10 (doesn't work for --scratch build because it's fc10 package)
New spec looks good. Passes Review
Thanks for review. Note: Package contains ExcludeArch: PPC for Fedora 10, see bug dependency. Trying to prepare workaround.
New Package CVS Request ======================= Package Name: kde-style-skulpture Short Description: Classical three-dimensional style for KDE Owners: jreznik Branches: F-9 F-10 InitialCC:
cvs done.
kde-style-skulpture-0.2.2-4.fc9 has been submitted as an update for Fedora 9. http://admin.fedoraproject.org/updates/kde-style-skulpture-0.2.2-4.fc9
kde-style-skulpture-0.2.2-4.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/kde-style-skulpture-0.2.2-4.fc10
kde-style-skulpture-0.2.2-4.fc9 has been pushed to the Fedora 9 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing-newkey update kde-style-skulpture'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F9/FEDORA-2009-3156
kde-style-skulpture-0.2.2-4.fc10 has been pushed to the Fedora 10 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update kde-style-skulpture'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F10/FEDORA-2009-3215
kde-style-skulpture-0.2.2-4.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report.
kde-style-skulpture-0.2.2-4.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report.