Spec URL: http://people.redhat.com/pvrabec/scap/openscap.spec SRPM URL: http://people.redhat.com/pvrabec/scap/openscap-0.1.3-1.fc9.src.rpm Description: OpenSCAP is a set of open source libraries providing an easier path for integration of the SCAP line of standards. SCAP is a line of standards managed by NIST with the goal of providing a standard language for the expression of Computer Network Defense related information.
Peter, the "fedora‑review" flag set to "?" means "someone is actively working on the review", not "the package needs to be reviewed", as you seem to think...
Peter you should read http://fedoraproject.org/wiki/Package_Review_Process#Contributor
Results of a brief look at the spec: > Source0: %{name}-%{version}.tar.gz Full URL is missing here. > Requires(post): /sbin/ldconfig > Requires(postun): /sbin/ldconfig These two are automatic/implicit already because -p is used with %post/%postun. > %files > %defattr(-,root,root,-) > %doc AUTHORS COPYING ChangeLog INSTALL NEWS README In case this is the standard 'INSTALL' file, it is irrelevant to RPM package users. > %package devel > License: LGPLv2+ > Requires: pkgconfig > %package python > License: LGPLv2+ > Requires: pkgconfig Neither of these two subpackages need pkg-config. The License tag need not be defined for subpackages as it is copied from the main package. You only need to redefine it if the licence of a subpackage differs from the main pkg actually. Anyone who will review this, %doc docs may need a close look.
Spec URL: http://people.redhat.com/pvrabec/scap/openscap.spec SRPM URL: http://people.redhat.com/pvrabec/scap/openscap-0.1.3-2.fc9.src.rpm
rpmlint output: openscap.i386: E: zero-length /usr/share/doc/openscap-0.1.3/NEWS openscap-python.i386: W: no-documentation The package contains no documentation (README, doc, etc). You have to include documentation files. 5 packages and 0 specfiles checked; 1 errors, 1 warnings. # The package must be named according to the Package Naming Guidelines . + Ok # The spec file name must match the base package %{name}, in the format %{name}.spec. + Ok # The package must meet the Packaging Guidelines. - NOT Ok - %doc in the -python subpackage is missing - %doc in the -devel subpackage installs the documentation files in docs/ directory (/usr/share/doc/openscap.../docs/) which is redundant. - %doc in the -devel subpackage installs unneeded files: Doxyfile # The package must be licensed with a Fedora approved license and meet the Licensing Guidelines. # The License field in the package spec file must match the actual license + Ok # If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package must be included in %doc. + Ok # The spec file must be written in American English. + Probably ok :] # The spec file for the package MUST be legible. + Ok # The sources used to build the package must match the upstream source. + Ok + MD5(UPSTREAM/openscap-0.1.3.tar.gz)= 99afff85b6884fd422013db99cf61f62 + MD5( SOURCES/openscap-0.1.3.tar.gz)= 99afff85b6884fd422013db99cf61f62 # The package MUST successfully compile and build into binary rpms on at least one primary architecture. + Ok + dist-f10: http://koji.fedoraproject.org/koji/taskinfo?taskID=1264946 + dist-f11: http://koji.fedoraproject.org/koji/taskinfo?taskID=1264952 # All build dependencies must be listed in BuildRequires. + Ok # Every binary RPM package (or subpackage) which stores shared library files (not just symlinks) in any of the dynamic linker's default paths, must call ldconfig in %post and %postun. + Ok # A package must own all directories that it creates. + Ok # A Fedora package must not list a file more than once in the spec file's %files listings. + Ok # Permissions on files must be set properly. Executables should be set with executable permissions, for example. Every %files section must include a %defattr(...) line. + Ok # Each package must have a %clean section, which contains rm -rf %{buildroot} (or $RPM_BUILD_ROOT). + Ok # Each package must consistently use macros. + Ok # The package must contain code, or permissable content. + Ok # If a package includes something as %doc, it must not affect the runtime of the application. + Ok # Header files must be in a -devel package. + Ok # If a package contains library files with a suffix, then library files that end in .so (without suffix) must go in a -devel package. + Ok # In the vast majority of cases, devel packages must require the base package using a fully versioned dependency: Requires: %{name} = %{version}-%{release} + Ok # Packages must NOT contain any .la libtool archives, these must be removed in the spec if they are built. + Ok # Packages must not own files or directories already owned by other packages. + Ok # At the beginning of %install, each package MUST run rm -rf %{buildroot} + Ok
Spec URL: http://people.redhat.com/pvrabec/scap/openscap.spec SRPM URL: http://people.redhat.com/pvrabec/scap/openscap-0.1.4-1.fc9.src.rpm + upgrade + doc fixes for -devel subpackage ! python subpackage is without documentation files yet, because it's in very early stage. Documentation files will be provided as soon as possible.
New Package CVS Request ======================= Package Name: openscap Short Description: Set of open source libraries enabling integration of the SCAP line of standards Owners: pvrabec Branches: F-10 InitialCC:
cvs done.