Bug 492019 - Review Request: cfourcc - Change the FOURCC of an MPEG4 or DivX video.
Review Request: cfourcc - Change the FOURCC of an MPEG4 or DivX video.
Status: CLOSED NOTABUG
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
low Severity medium
: ---
: ---
Assigned To: Nobody's working on this, feel free to take it
Fedora Extras Quality Assurance
:
Depends On:
Blocks: FE-DEADREVIEW
  Show dependency treegraph
 
Reported: 2009-03-24 19:49 EDT by Yannik Stadelmaier
Modified: 2009-09-27 15:33 EDT (History)
5 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2009-09-27 15:33:58 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:


Attachments (Terms of Use)
patch to fix b) from comment #2 (579 bytes, patch)
2009-03-26 00:15 EDT, Ralf Corsepius
no flags Details | Diff
cfourcc.spec Version 2 (1.02 KB, application/octet-stream)
2009-03-26 04:41 EDT, Yannik Stadelmaier
no flags Details

  None (edit)
Description Yannik Stadelmaier 2009-03-24 19:49:18 EDT
Spec URL: http://freeki.de/fedora/cfourcc.spec
SRPM URL: http://freeki.de/fedora/cfourcc-0.1.2-1.fc10.src.rpm
Description: With cfourcc you could change the FOURCC of an MPEG4 or DIVX video on the command line.

The Problem with this programm is, that it only uses make install (wich includes the build-process) instead of make && make install.
Comment 1 Tim Lauridsen 2009-03-25 08:18:35 EDT
i think you shall use 'GPVv2+' as license based on the the header in the source file.

<snip>
    This program is free software; you can redistribute it and/or modify
    it under the terms of the GNU General Public License as published by
    the Free Software Foundation; either version 2 of the License, or
    (at your option) any later version.
</snip>
Comment 2 Ralf Corsepius 2009-03-26 00:13:20 EDT
(In reply to comment #0)
Amazing, how broken even trivial Makefiles can be ;)

MUSTFIX:
a) Compilation doesn't acknowledge RPM_OPT_FLAGS.
Normally, this can be achieved by overriding the Makefile's CFLAGS:
make %{?_smp_mflags} CFLAGS="${RPM_OPT_FLAGS}"

However, provided the brokenness of the Makefile, and the simplicity of this package (one single c-file), I am inclined to recommend not to use the Makefile at all, but to compile the file directly:
%{__cc} $RPM_OPT_FLAGS -o cfourcc cfourcc.c


b) When having changed compilation to using $RPM_OPT_FLAGS, the compiling the package trips over bugs inside of the sources.

This breakdown needs patching.


c) rpmlint complains:
cfourcc.x86_64: W: summary-ended-with-dot Change the FOURCC of an MPEG4 or DivX video.
cfourcc.x86_64: E: description-line-too-long With cfourcc you could change the FOURCC of an MPEG4 or DIVX video on the command line.
Comment 3 Ralf Corsepius 2009-03-26 00:15:05 EDT
Created attachment 336750 [details]
patch to fix b) from comment #2
Comment 4 Yannik Stadelmaier 2009-03-26 04:41:24 EDT
Created attachment 336761 [details]
cfourcc.spec Version 2

Here is the new cfourcc.spec

I changed the description (just added a line break) and included the patch.

Here you can find the new srpm:
http://freeki.de/fedora/cfourcc-0.1.2-2.fc10.src.rpm
Comment 5 Simon 2009-09-11 01:41:45 EDT
afairr, yanstadel isn't active in the fedoraproject

Note You need to log in before you can comment on or make changes to this bug.