Bug 492039 - (perl-Jemplate) Review Request: perl-Jemplate - JavaScript Templating with Template Toolkit
Review Request: perl-Jemplate - JavaScript Templating with Template Toolkit
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
All Linux
low Severity medium
: ---
: ---
Assigned To: Parag AN(पराग)
Fedora Extras Quality Assurance
Depends On:
  Show dependency treegraph
Reported: 2009-03-24 21:50 EDT by Chris Weyl
Modified: 2009-03-28 21:13 EDT (History)
3 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Last Closed: 2009-03-28 21:13:11 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
panemade: fedora‑review+
kevin: fedora‑cvs+

Attachments (Terms of Use)

  None (edit)
Description Chris Weyl 2009-03-24 21:50:20 EDT
Spec URL: http://fedorapeople.org/~cweyl/review/perl-Jemplate.spec
SRPM URL: http://fedorapeople.org/~cweyl/review/perl-Jemplate-0.23-1.fc10.src.rpm

Jemplate is a templating framework for JavaScript that is built over
Perl's Template Toolkit (TT2). Jemplate parses TT2 templates using the
TT2 Perl framework, but with a twist. Instead of compiling the templates
into Perl code, it compiles them into JavaScript. Jemplate then provides
a JavaScript runtime module for processing the template code. Presto, we
have full featured JavaScript templating language!

Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1257482

Comment 1 Parag AN(पराग) 2009-03-25 00:31:31 EDT
+ package builds in mock (rawhide i586).
koji Build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1257482
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
208799c450df16134949ee031b92eef4  Jemplate-0.23.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test gave
All tests successful.
Files=20, Tests=140, 22 wallclock secs ( 0.12 usr  0.02 sys +  9.59 cusr  0.71 csys = 10.44 CPU)
+ Package perl-Jemplate-0.23-1.fc11.noarch =>
Provides: perl(Jemplate) = 0.23 perl(Jemplate::Directive) perl(Jemplate::Grammar) = 2.10 perl(Jemplate::Parser) perl(Jemplate::Runtime) perl(Jemplate::Runtime::Compact)
Requires: /usr/bin/perl perl >= 0:5.004 perl >= 0:5.006001 perl(Getopt::Long) perl(Jemplate) >= 0.22 perl(Jemplate::Directive) perl(Jemplate::Grammar) perl(Jemplate::Parser) perl(Template) >= 2.14 perl(base) perl(lib) perl(strict) perl(vars) perl(warnings)

Comment 2 Chris Weyl 2009-03-25 02:58:49 EDT
New Package CVS Request
Package Name: perl-Jemplate
Short Description: JavaScript Templating with Template Toolkit
Owners: cweyl
Branches: F-9 F-10 devel
InitialCC: perl-sig
Comment 3 Kevin Fenzi 2009-03-27 16:38:15 EDT
cvs done.
Comment 4 Chris Weyl 2009-03-28 21:13:11 EDT
Thanks for the review! :-)

Note You need to log in before you can comment on or make changes to this bug.