Bug 492165 - Review Request: rotoscope - A free rotoscoping application.
Review Request: rotoscope - A free rotoscoping application.
Status: CLOSED DUPLICATE of bug 599324
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
low Severity medium
: ---
: ---
Assigned To: Nobody's working on this, feel free to take it
Fedora Extras Quality Assurance
:
Depends On:
Blocks: FE-DEADREVIEW
  Show dependency treegraph
 
Reported: 2009-03-25 13:31 EDT by Yannik Stadelmaier
Modified: 2010-06-03 02:27 EDT (History)
6 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2009-05-21 12:37:55 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---


Attachments (Terms of Use)

  None (edit)
Description Yannik Stadelmaier 2009-03-25 13:31:00 EDT
Spec URL: http://freeki.de/fedora/rotoscope.spec
SRPM URL: freeki.de/fedora/rotoscope-0.2-1.fc10.src.rpm
Description: Rotoscope is a free software rotoscoping application
that can be used to give photos a cartoon-like appearance.
This is similar to the technique used in movies
such as Waking Life and A Scanner Darkly.
Comment 1 Kalev Lember 2009-03-27 19:55:07 EDT
Some initial comments:

1) You have a typo in %install section. It should read %{buildroot}, not %{buidroot}.

2) A package should own all the directories it creates, otherwise it will leave empty directories behind when you uninstall it. Change:
%{_datadir}/%{name}/%{name}.*
to:
%{_datadir}/%{name}/

3) remove dot at the end of summary line;

4) NEWS file seems to be empty, so just don't install it;

5) rpmlint complains about mixed-use-of-spaces-and-tabs;

6) in the SRPM file you have execute bit set on both the spec file and the patch;

7) Licence is wrong. It seems to be GPLv2+, not GPLv2 as you have set in the spec file.
Comment 2 Mamoru TASAKA 2009-04-14 13:02:23 EDT
Yannik, would you address issues pointed out by Kalev
and reupload the new spec/srpm (with Epoch-Version-Release
changed)?
Comment 3 Mamoru TASAKA 2009-04-26 14:21:41 EDT
ping again?
Comment 4 Mamoru TASAKA 2009-05-10 05:08:04 EDT
again ping?
Comment 5 Mamoru TASAKA 2009-05-14 11:28:00 EDT
I will close this bug as NOTABUG if no response is received
from the reporter within ONE WEEK.
Comment 6 Mamoru TASAKA 2009-05-21 12:37:55 EDT
Once closing.

If someone wants to import this package into Fedora, please
file a new review request and mark this bug as a duplicate
of the new one.

Thank you!
Comment 7 Tareq Al Jurf 2010-06-03 02:27:06 EDT

*** This bug has been marked as a duplicate of bug 599324 ***

Note You need to log in before you can comment on or make changes to this bug.