Spec URL: http://oget.fedorapeople.org/review/dssi-vst.spec SRPM URL: http://oget.fedorapeople.org/review/dssi-vst-0.8-1.fc10.src.rpm Description: dssi-vst is an adapter that allows users of Linux audio software to take VST and VSTi audio effects and instrument plugins compiled for Windows, and load them into native LADSPA or DSSI plugin hosts. Plugins run at full speed for most audio processing, although their user interfaces are slower because of the Windows emulation. rpmlint is silent.
I separated the wine related parts in a -wine subpackage. This subpackage will be built only on ix86 and I will ask releng to push the ix86 package to x86_64 repo. This way we will keep all ix86 and x86_64 users happy. Spec URL: http://oget.fedorapeople.org/review/dssi-vst.spec SRPM URL: http://oget.fedorapeople.org/review/dssi-vst-0.8-2.fc10.src.rpm Changelog: 0.8-2 - Make a ix86 only -wine subpackage Builds fine in koji rawhide: http://koji.fedoraproject.org/koji/taskinfo?taskID=1330071 Question: Should I change the name of the -wine subpackage to something else (like -wrapper)?
Fedora review dssi-vst-0.8-2.fc10.src.rpm 2009-05-29 $ rpmlint *.rpm *.spec dssi-vst-wine.i386: W: no-documentation 7 packages and 1 specfiles checked; 0 errors, 1 warnings. * OK ? needs attention * rpmlint is OK * package is named according to guidelines * specfile is named after the package * package is licensed under a Fedora approved license (GPLv2) * package license corresponds to the license of the package sources * license file (COPYING) is included as %doc * specfile is written in legible English * sources matches upstream $ md5sum dssi-vst-0.8.tar.gz SRPM/dssi-vst-0.8.tar.gz 2d46474eaf84f0a2efc2389edaa18e3a dssi-vst-0.8.tar.gz 2d46474eaf84f0a2efc2389edaa18e3a SRPM/dssi-vst-0.8.tar.gz * package builds in mock in ix86 and x86_64 (Fedora 10) * package has exclusive arch for ix86 and x86_64 (requires wine) * BuildRequires are sane * package owns all directories it creates - both the main and wine subpackages own /usr/lib/dssi/dssi-vst, but that is necessary since the packages Require each other * no duplicate files * permissions are sane and %files has %defattr * %clean clears buildroot * specfile uses macros consistently * package contains code * subpackage interdepencies used fully qualified versions ? the wine subpackage owns /usr/lib/dssi which is also owned by the dssi package - should the wine subpackage require dssi instead? * %install clears buildroot * installed filenames are UTF8 The minor issue above you can fix post-review. Package approved.
(In reply to comment #2) > Fedora review dssi-vst-0.8-2.fc10.src.rpm 2009-05-29 > Thank you for the review! > ? the wine subpackage owns /usr/lib/dssi which is also owned by the > dssi package - should the wine subpackage require dssi instead? > There is a subtlety here. I first thought of doing it that way but then I realized that it would be problematic on x86_64. On x86_64, when someone installs dssi-vst, the dssi-vst.x86_64 dssi-vst-wine.i586 packages will be installed. If I put a Requires: dssi on the dssi-vst-wine package, it will pull dssi.x86_64 during installation, and dssi.x86_64 does not own /usr/lib/dssi. The only solution I found was to own /usr/lib/dssi by dssi-vst-wine.i586 so that we have all directories owned in all archs. Please let me know if you find a better solution. New Package CVS Request ======================= Package Name: dssi-vst Short Description: DSSI plugin wrapper for VST plugins Owners: oget Branches: F-9 F-10 F-11 InitialCC:
CVS done.
dssi-vst-0.8-2.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/dssi-vst-0.8-2.fc11
dssi-vst-0.8-2.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/dssi-vst-0.8-2.fc10
dssi-vst-0.8-2.fc9 has been submitted as an update for Fedora 9. http://admin.fedoraproject.org/updates/dssi-vst-0.8-2.fc9
(In reply to comment #3) > > There is a subtlety here. I first thought of doing it that way but then I > realized that it would be problematic on x86_64. On x86_64, when someone > installs dssi-vst, the > dssi-vst.x86_64 > dssi-vst-wine.i586 > packages will be installed. If I put a > Requires: dssi > on the dssi-vst-wine package, it will pull dssi.x86_64 during installation, and > dssi.x86_64 does not own /usr/lib/dssi. The only solution I found was to own > /usr/lib/dssi by dssi-vst-wine.i586 so that we have all directories owned in > all archs. > > Please let me know if you find a better solution. I see your point here.
dssi-vst-0.8-2.fc10 has been pushed to the Fedora 10 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update dssi-vst'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F10/FEDORA-2009-5732
dssi-vst-0.8-2.fc9 has been pushed to the Fedora 9 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing-newkey update dssi-vst'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F9/FEDORA-2009-5736
dssi-vst-0.8-2.fc11 has been pushed to the Fedora 11 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update dssi-vst'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F11/FEDORA-2009-5791
dssi-vst-0.8-3.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/dssi-vst-0.8-3.fc11
dssi-vst-0.8-3.fc11 has been pushed to the Fedora 11 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update dssi-vst'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F11/FEDORA-2009-5820
dssi-vst-0.8-3.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report.
dssi-vst-0.8-2.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report.
dssi-vst-0.8-2.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report.