Red Hat Bugzilla – Bug 492490
RFE: include contrib/ in %doc
Last modified: 2013-01-10 05:31:34 EST
The Git tarball has a rich contrib/ directory. I see some of these are already included in various subpackage's %doc, but can we include all of it somewhere? I can see it being useful to be able to do access these without having to go poking through the sources :-)
Sounds reasonable to me. I know there have been things in contrib/ that I've had to grab here and there. Just a few concerns I have off the top of my head...
We include contrib/hooks currently, which ends up at /usr/share/doc/git-*/hooks. I wonder if anyone will get annoyed if we include contrib/, and then the hooks end up at /usr/share/doc/git-*/contrib/hooks? The version changes frequently, so it seems reasonable to assume anyone using that has to do manual work anyway. Besides, they should be using the hooks from /usr/share/git-core/templates/hooks/ instead.
If we don't go to some effort to exclude files that are included elsewhere, won't we run afoul of https://fedoraproject.org/wiki/Packaging:Guidelines#Duplicate_Files ? We already do duplicate some %doc files, but I haven't had time to see about fixing that yet.
I'm guessing we'll also pick up some rpmlint complaints, some of which may be things we can ignore -- though it's nice to keep the the output to a minimum, so actual problems can be spotted.
And somewhere in the back of my mind, I think I recall reading that rpm picks up requires/provides even in %doc files? If that's true, we'll have to watch that we don't pick up any spurious requires/provides. (I'd be happy to be told I'm just delirious from lack of rum and that this isn't a problem. ;)
I just built git-22.214.171.124-1.fc11 for rawhide and it includes the contrib dir. I stripped execute perms from any files that had them, to avoid a lot of rpmlint complaining and the possibility of picking up unintended requires/provides. Yell if you notice any problems with this.