Spec URL: http://cassmodiah.fedorapeople.org/griffith-0.9.9/griffith.spec SRPM URL: http://cassmodiah.fedorapeople.org/griffith-0.9.9/griffith-0.9.9-1.fc11.src.rpm Description: Griffith is a media collection manager application. Adding items to the collection is as quick and easy as typing the film title and selecting a supported source. Griffith will then try to fetch all the related information from the Web. This Version comes with SQLite support. You need to install * the package "MySQL-python" for MySQL-support * the package "python-psycopg2" for PostgreSQL-support
I reviewed this package. There are a few minor things to go over: * The binary .mo files need to be removed in %prep and be built from the source .po files. * lib/sqlalchemy shouldn't be packaged since it is a duplicate of the python-sqlalchemy package. ! I don't think issuing "make" is necessary. It doesn't build anything. Hence the %build section should be empty. ! Please make the description span 80 columns, AND/OR separate new paragraphs by blank lines. ! Normally, I prefer supplying such wrapper scripts as separate sources. This is also useful to preserve the original creation date. Since it is such a small and trivial script in this case, it shouldn't matter. But I leave it up to your consideration.
update to 0.10-beta2 without internal dependency sqlalchemy needs sqlalchemy 0.5 or higher works well in rawhide SPEC http://cassmodiah.fedorapeople.org/griffith-0.10-beta2/griffith.spec SRPM http://cassmodiah.fedorapeople.org/griffith-0.10-beta2/griffith-0.10-0.1+beta2.fc10.src.rpm for F11 or higher only
You will need to replace the + in the release field with a . The guidelines say: "the period '.' should be used as the delimiter between the release number increment, and the non-numeric version string." ref: http://fedoraproject.org/wiki/Packaging/NamingGuidelines#Pre-Release_packages Otherwise the package is good to go. Please do the above change before you commit. ------------------------------------------- This package (griffith) is APPROVED by oget -------------------------------------------
thank you very much for your review, Orcan! yeah i will replace the + with the . before i commit New Package CVS Request ======================= Package Name: griffith Short Description: Media collection manager Owners: cassmodiah Branches: F11 InitialCC:
Just a note that I had already submitted griffith long before you did at https://bugzilla.redhat.com/show_bug.cgi?id=458402 Overriding it by submitting a different review request just means that quite a bit of work has been duplicated which is unfortunate. In the normal course, I would have just marked it as a duplicate but since it has been already approved, maybe you can compare the spec and see if there any useful improvements you can copy?
Oops, we (me and Simon) both missed that. Comparing the SRPM's I see that both has its advantages. Rahul's package has the extra artwork (but its source should be mentioned in the SPEC file). On the other hand, Simon's package does not duplicate the python-sqlalchemy package. I can revoke my approval. But since this one passed the review already, would you like to maintain it together? It's Rahul's call, I'm fine either way.
I have no personal interest in it. Someone asked in Fedora India list and I offered to do it with them. If you can integrate the useful portions of my spec file such as the extra artwork, that would be nice. Can be done post import as well. Artwork source is the same place as the software itself http://download.berlios.de/griffith/griffith-extra-artwork-0.9.4.tar.gz
cvs done.
thank you Kevin. I will take a look next week to include the artwork. Thank you for your hint Rahul
*** Bug 458402 has been marked as a duplicate of this bug. ***
griffith-0.10-0.1.beta2.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/griffith-0.10-0.1.beta2.fc11
griffith-0.10-0.1.beta2.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report.