Created attachment 337249 [details]
patch for qemu-dm via xend to allow for unix-domain-socket serial files

Description of problem:
Per XML spec:
http://libvirt.org/formatdomain.html#elementsCharUNIX
This should be allowed:
<serial type="unix">
  <source mode="bind" path="/path/to/serial"/>
  <target port="1"/>
</serial>

The xend log reports for the "qemu-dm" command it is using:
[..., '-serial', 'unix:/path/to/serial,listen', ...]

the "listen" part is not valid, it should be ",server,nowait"
like is currently specified in qemu_conf.c

A similar patch to the one applied to qemu_conf.c need to be applied to xend_internal.c also.

I will attach the patch (diff from git trunk).

Version-Release number of selected component (if applicable):

git trunk (all versions?)


How reproducible:

Steps to Reproduce:
1. Create any XEN DomU via Libvirt with Unix Domain Socket for serial
  
Actual results:

DomU fails to start, with DM error logged to /var/log/xen/qemu-dm.<name>.log


Expected results:

DomU starts and creates Unix Domain Socket at specified path.


Additional info: