Red Hat Bugzilla – Bug 493521
Review Request: perl-Log-Trace - A unified approach to tracing
Last modified: 2009-04-05 13:19:09 EDT
Spec URL: http://fedorapeople.org/~cweyl/review/perl-Log-Trace.spec
SRPM URL: http://fedorapeople.org/~cweyl/review/perl-Log-Trace-1.070-1.fc10.src.rpm
This module provides a unified approach to tracing. A script can 'use
Log::Trace qw( < mode > )' to set the behaviour of the TRACE function.By
default, the trace functions are exported to the calling package only.
You can export the trace functions to other packages with the 'Deep'
option. See the "OPTIONS" manpage for more information.
Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1272037
+ package builds in mock (rawhide i586).
koji Build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1272037
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test gave
All tests successful.
Files=13, Tests=80, 0 wallclock secs ( 0.05 usr 0.03 sys + 0.38 cusr 0.08 csys = 0.54 CPU)
+ Package perl-Log-Trace-1.070-1.fc11.noarch =>
Provides: perl(Log::Trace) = 1.070
Requires: perl(Carp) perl(Fcntl) perl(strict) perl(vars)
Can you please help me understand why to use AutoProv and why not to filter and remove unnecessary provides perl(DB)?
(In reply to comment #1)
> Can you please help me understand why to use AutoProv and why not to filter and
> remove unnecessary provides perl(DB)?
Sure :-) DB is used by the Perl debugger, and as such, is sometimes poked at... It shouldn't be provided by this package. In this case, turning off autoprov and manually providing perl(Log::Trace) is significantly easier than filtering the two provides autoprov finds. ...we've also done this before, e.g. perl-DateTime-Format-DBI.
Thanks for explanation.
New Package CVS Request
Package Name: perl-Log-Trace
Short Description: A unified approach to tracing
Branches: F-9 F-10 devel
Thanks for the review! :-)
(In reply to comment #2)
> (In reply to comment #1)
> > Can you please help me understand why to use AutoProv and why not to filter and
> > remove unnecessary provides perl(DB)?
> Sure :-) DB is used by the Perl debugger, and as such, is sometimes poked
> at... It shouldn't be provided by this package. In this case, turning off
> autoprov and manually providing perl(Log::Trace) is significantly easier than
> filtering the two provides autoprov finds. ...we've also done this before,
> e.g. perl-DateTime-Format-DBI.
@Chis: Please understand that I do not agree with your rationale. I consider this kind of packaging to be grossly negligant sloppiness.