Red Hat Bugzilla – Bug 493527
Review Request: perl-PlRPC - Interface for building pServer Clients
Last modified: 2009-05-07 02:53:23 EDT
Spec URL: http://fedorapeople.org/~cweyl/review/perl-PlRPC.spec
SRPM URL: http://fedorapeople.org/~cweyl/review/perl-PlRPC-0.2020-1.fc10.src.rpm
PlRPC (Perl RPC) is a package that simplifies the writing of Perl based
client/server applications. RPC::PlServer is the package used on the
server side, and you guess what RPC::PlClient is for. PlRPC works by
defining a set of methods that may be executed by the client.
Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1272115
+ package builds in mock (rawhide i586).
koji Build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1272115
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test gave
All tests successful.
+ Package perl-PlRPC-0.2020-1.fc11.noarch =>
Provides: perl(Bundle::PlRPC) = 0.03 perl(RPC::PlClient) = 0.2020 perl(RPC::PlClient::Comm) = 0.1002 perl(RPC::PlClient::Object) perl(RPC::PlServer) = 0.2020 perl(RPC::PlServer::Comm) = 0.1003 perl(RPC::PlServer::Test) = 0.01
Requires: perl >= 0:5.004 perl(IO::Socket) perl(Net::Daemon) perl(Net::Daemon::Log) perl(Net::Daemon::Test) perl(RPC::PlClient::Comm) perl(RPC::PlServer) perl(RPC::PlServer::Comm) perl(Storable) perl(strict) perl(vars)
ah sorry forgot to remove make test checkitem from above review as there is no make check for this package used.
New Package CVS Request
Package Name: perl-PlRPC
Short Description: Interface for building pServer Clients
Branches: F-9 F-10 devel
Thanks for the review! :-)
Chris: I'll be very thankful if this was in EPEL-5 as well. Could you please request an EL-5 branch (I'd gladly do that if you have a reason for not maintaining it there).