Red Hat Bugzilla – Bug 493531
Review Request: perl-Test-Most - Test::Most Perl module
Last modified: 2014-04-05 15:36:40 EDT
Spec URL: http://mmaslano.fedorapeople.org/review/perl-Test-Most.spec
SRPM URL: http://mmaslano.fedorapeople.org/review/perl-Test-Most-0.21-1.fc11.src.rpm
Description: Most commonly needed test functions and features.
will you please check if Requires: lines are really needed in this package?
For perl packages dependencies are automatically resolved at time of their installation using yum.
Only those dependencies that yum fails to pick/resolve are needed to be explicitly added in spec file as Requires
Checked. Most of requirement are really needed but few were removed.
Ping? This is blocking another package, which was already accepted.
The reason I did not review this because I am continually checking updates here.
DEBUG util.py:256: No Package Found for perl(Data::Dumper::Names) >= 0.03
koji build for above log is
Also I see package perl-Data-Dumper-Names is not built successfully yet http://koji.fedoraproject.org/koji/packageinfo?packageID=8109
I also found failed build for perl-Data-Dumper-Names at http://koji.fedoraproject.org/koji/buildinfo?buildID=97060
So I think I cannot proceed here until koji allows to build this package successfully.
Omg, it's all about cyclic dependency :) Now I switched off tests in perl-Data-Dumper-Names, which needs perl-Test-Most, which needs perl-Data-Dumper-Names as BR.
In an hour or so, it should perl-Data-Dumper-Names be in buildroot and this package will succeed.
Failed build http://koji.fedoraproject.org/koji/taskinfo?taskID=1299787
Attempted again to mock build at koji
The problem was with tag. Because perl-Data-Dumper-Names are tagged into
dist-f11-updates-candidate or dist-f12 and my scratch builds were into dist-f11, which doesn't know about perl-Data-Dumper-Names.
As already said please remove following from SPEC
Requires: perl(Data::Dumper::Names) >= 0.03
Requires: perl(Exception::Class) >= 1.14
Requires: perl(Test::Warn) >= 0.1
I have tested again with yum install command and I see all those are automatically installed.
Also, I have seen in most of your perl package submissions that you also uses
BuildRequires: perl >= 0:5.006
This is not needed.
Please submit new SRPM
sorry mistakenly changed flags to fedora-review+
New Package CVS Request
Package Name: perl-Test-Most
Short Description: Most commonly needed test functions and features
After freeze of F-11 it will be build as perl-Test-Most-0.21-3.fc11.
Package Change Request
Package Name: perl-Test-Most
New Branches: el5 el6
I (pghmcfc) am already maintainer of perl-Test-Most for EPEL-7.
Git done (by process-git-requests).
perl-Test-Most-0.21-4.el6,perl-Data-Dumper-Names-0.03-17.el6 has been submitted as an update for Fedora EPEL 6.
perl-Test-Most-0.21-4.el6, perl-Data-Dumper-Names-0.03-17.el6 has been pushed to the Fedora EPEL 6 stable repository.