Bug 493823 - S-c-tools cleanup: dialogs centered on screen/main application window
Summary: S-c-tools cleanup: dialogs centered on screen/main application window
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: system-config-kickstart
Version: rawhide
Hardware: All
OS: Linux
low
medium
Target Milestone: ---
Assignee: Chris Lumens
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 493602
TreeView+ depends on / blocked
 
Reported: 2009-04-03 09:52 UTC by Roman Rakus
Modified: 2014-01-13 00:08 UTC (History)
3 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2009-04-13 14:52:57 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)
patch (620.87 KB, patch)
2009-04-08 14:56 UTC, Roman Rakus
no flags Details | Diff
Patch, used glade2 (16.42 KB, patch)
2009-04-09 14:24 UTC, Roman Rakus
no flags Details | Diff

Description Roman Rakus 2009-04-03 09:52:27 UTC
Description of problem:
Child dialogs should be centered on parent window, not on screen/main application window.

How reproducible: 
about, open/save etc.

Steps to Reproduce:
1. invoke some dialog (for example About dialog)
2. check dialog centering

Actual results:
Dialogs centered on screen/main application window.

Expected results:
Dialogs centered on parent window.

Additional info:
This bug report is part of "System Configuration Tools Cleanup Project". Don't hesitate to ask project maintainers for any kind of help.

Comment 1 Roman Rakus 2009-04-08 13:28:05 UTC
I'll take care of this one...

Comment 2 Roman Rakus 2009-04-08 14:56:41 UTC
Created attachment 338719 [details]
patch

Patch that fixes this bug.
Just one issue - my glade editor made .glade file much more different, so the path file looks ugly :(

Comment 3 Roman Rakus 2009-04-08 14:58:25 UTC
Chris, will you apply the patch? Or will you add me to package as co-maintainer, or will you provide me push access to upstream repo, or...?

Comment 4 Chris Lumens 2009-04-08 17:26:26 UTC
Sure, I'll apply any patches after checking them to make sure they're good.  I appreciate the work.  I'm hesitant to apply the .glade file chunk after seeing how huge it is.  Could you tell me what you did there and I can make the changes myself to keep the diff smaller?  Thanks.

Comment 5 Roman Rakus 2009-04-09 09:54:52 UTC
For every dialog|window I set:
Window position: Center on parent
Transient for: main_window
That's all.

Comment 6 Roman Rakus 2009-04-09 14:24:23 UTC
Created attachment 338917 [details]
Patch, used glade2

With glade2 patch looks prettier...

Comment 7 Chris Lumens 2009-04-13 14:52:57 UTC
Thanks for the updated patch.  This will be included in the next build of system-config-kickstart.


Note You need to log in before you can comment on or make changes to this bug.