We get massive stacktraces when we try to create kickstart profiles in Spacewalk with 0.5 and Cobbler 1.6. This requires a change on both sides: Cobbler: http://tinyurl.com/cyvkyg Spacewalk: Removal of \n from returned strings: diff --git a/java/code/src/com/redhat/rhn/manager/kickstart/cobbler/CobblerXMLRPCHelper.java b/java/code/src/com/redhat/rhn/manager/kickstart/cobbler/CobblerXMLRPCHelper.java index 5510ba1..63539f2 100644 --- a/java/code/src/com/redhat/rhn/manager/kickstart/cobbler/CobblerXMLRPCHelper.java +++ b/java/code/src/com/redhat/rhn/manager/kickstart/cobbler/CobblerXMLRPCHelper.java @@ -71,9 +71,6 @@ public class CobblerXMLRPCHelper implements XMLRPCInvoker { catch (XmlRpcException e) { throw new RuntimeException("XmlRpcException calling cobbler.", e); } - if (retval instanceof String) { - retval = retval + "\n"; - } return retval; } diff --git a/java/code/src/org/cobbler/CobblerConnection.java b/java/code/src/org/cobbler/CobblerConnection.java index 51d4300..8ec8b74 100644 --- a/java/code/src/org/cobbler/CobblerConnection.java +++ b/java/code/src/org/cobbler/CobblerConnection.java @@ -115,18 +115,14 @@ public class CobblerConnection { * @return Object returned. */ private Object invokeMethod(String procedureName, List args) { - log.debug("procedure: " + procedureName + " Orig ags: " + args); + log.debug("procedure: " + procedureName + " ags: " + args); Object retval; try { - log.debug("args array: " + args); retval = client.invoke(procedureName, args); } catch (Exception e) { throw new XmlRpcException("XmlRpcException calling cobbler.", e); } - if (retval instanceof String) { - retval = retval + "\n"; - } return retval; }
Spacewalk 0.5 released.
Spacewalk 0.5 has been released for long time ago.