Bug 494416 - simplify mkdumprds use of mount when mounting rootfs
Summary: simplify mkdumprds use of mount when mounting rootfs
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: kexec-tools
Version: 11
Hardware: All
OS: Linux
low
medium
Target Milestone: ---
Assignee: Neil Horman
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2009-04-06 19:34 UTC by Neil Horman
Modified: 2009-09-29 06:06 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2009-09-29 06:06:25 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Neil Horman 2009-04-06 19:34:52 UTC
Description of problem:
Lubomir Rintel <lkundrak> passed this to me.  It simplifies our mounting of the rootfs:

--- ./mkdumprd.rootfs   2009-04-05 21:37:33.099237275 +0200
+++ ./mkdumprd  2009-04-05 21:37:40.423233727 +0200
@@ -2102,19 +2102,9 @@ emit "fi"

 emit "echo Checking root filesystem."
 emit "fsck \$ROOTDEV"
-emit "echo Mounting root filesystem."
-emit "for FSTYPE in ext3 ext2 minix"
-emit "do"
-emit "  echo Trying mount -t \$FSTYPE \$ROOTDEV /sysroot"
-emit "  mount -t \$FSTYPE \$ROOTDEV /sysroot >/dev/null 2>&1 "
-emit "  if [ \$? == 0 ]"
-emit "  then"
-emit "      echo Using \$FSTYPE on root filesystem"
-emit "      ROOT_MOUNT_GOOD=1"
-emit "      break;"
-emit "  fi"
-emit "done"
-emit "if [ -z \"\$ROOT_MOUNT_GOOD\" ]"
+emit "echo Mounting root filesystem: mount -t $rootfs \$ROOTDEV /sysroot"
+emit "mount -t $rootfs \$ROOTDEV /sysroot >/dev/null 2>&1 "
+emit "if [ \$? != 0 ]"
 emit "then"
 emit "   echo unable to mount rootfs. Dropping to shell"
 emit "   /bin/msh"

Comment 1 Neil Horman 2009-04-07 13:57:30 UTC
fixed in -12.fc11.  Thanks!

Comment 2 Lubomir Rintel 2009-04-07 14:04:46 UTC
Thank you for applying this, Neil.

Comment 3 Bug Zapper 2009-06-09 13:21:33 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 11 development cycle.
Changing version to '11'.

More information and reason for this action is here:
http://fedoraproject.org/wiki/BugZappers/HouseKeeping


Note You need to log in before you can comment on or make changes to this bug.