The close button on top right of the window does not show up when qsynth is compiled and/run against qt4.5 which is going to hit F-9, F-10 repos soon. It is already in rawhide. Additionally, the locale .qm files get installed into %{_datadir}/locale. According to the guidelines, usage of %{_datadir}/locale/* is forbidden in %files section. These files are not regular locale files but they are qt style locale files. They need to be installed somewhere else, possibly in %{_datadir}/%{name}/locale I'm attaching patches to fix both issues. I also filed ACL requests in pkgdb: https://admin.fedoraproject.org/pkgdb/packages/name/qsynth I can fix these issues if I'm granted permission.
Created attachment 338449 [details] close button fix (qt4.5)
Created attachment 338450 [details] fix locale path
When/if new builds are done against qt-4.5, I'd also suggest adding (something like): Requires: qt4 >= %{_qt4_version} and it can be added to pending qt45 updates F-9: https://admin.fedoraproject.org/updates/F9/FEDORA-2009-3356 F-10: https://admin.fedoraproject.org/updates/F10/FEDORA-2009-3389 (or pushed separately, provided it doesn't land in stable before qt45 does).
I'm not convinced the locale path patch really makes sense. The spirit of the "%{_datadir}/locale/* is forbidden" guideline is that all language-specific files need to be qualified with %lang for that language (e.g. %lang(de)), which the %find_lang macro does for you (for standard .mo files). So throwing those files into a subdirectory does not actually fix anything. What is really needed is a %find_lang-type macro for Qt translations. (That or get the upstream projects to use gettext instead like the rest of the world, including KDE, does. But I'm sure there will always be projects using Qt's translation mechanism, starting from Qt itself.) IMHO we should get the Qt 4.5 fixes out ASAP and leave the locale issues for a later cleanup when we're not in a hurry. You should also file a separate bug for the locale stuff, 2 issues in one bug report = bad. The patch as it is there is IMHO wrong.
So, installing .qm files directly in /usr/share/locale/ = right ? If you look closely, the patch does not put them in a subdirectory of /usr/share/locale/; it puts them into /usr/share/%{name}/locale/
qsynth-0.3.3-6.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/qsynth-0.3.3-6.fc11
This one is done too.
qsynth-0.3.3-6.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report.